From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19611C4363A for ; Wed, 28 Oct 2020 09:18:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 912322419A for ; Wed, 28 Oct 2020 09:18:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 912322419A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C60956E4B5; Wed, 28 Oct 2020 09:18:18 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id CDD936E4B5 for ; Wed, 28 Oct 2020 09:18:17 +0000 (UTC) IronPort-SDR: 2WOXk1g3lJD9hCx2uNAgBc+uFJs/yIyUQ3InZZfdYMWCAqXblzSkujOBRA7tQ8XnPEs1PhVCLY yvFlgSGr8Y7Q== X-IronPort-AV: E=McAfee;i="6000,8403,9787"; a="147514259" X-IronPort-AV: E=Sophos;i="5.77,425,1596524400"; d="scan'208";a="147514259" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 02:18:17 -0700 IronPort-SDR: qZuznGRw7Opzog8USXKh6811OhzDl0EyLsy1CYtSb8eqwujRxGd331ILD796mmNdsApTKUGiXj 96muoljnDbrA== X-IronPort-AV: E=Sophos;i="5.77,425,1596524400"; d="scan'208";a="304177016" Received: from genxfsim-desktop.iind.intel.com (HELO intel.com) ([10.223.74.178]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 02:18:15 -0700 Date: Wed, 28 Oct 2020 14:34:39 +0530 From: Anshuman Gupta To: Kamati Srinivas Message-ID: <20201028090439.GJ29526@intel.com> References: <20201027103335.3725-1-srinivasx.k@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201027103335.3725-1-srinivasx.k@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] drm/i915: Acquire connector reference before prop_work X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "intel-gfx@lists.freedesktop.org" , "Pandey, Hariom" , "seanpaul@chromium.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 2020-10-27 at 16:03:35 +0530, Kamati Srinivas wrote: > From: Srinivas Kamati > > "Content protection type change" igt test results in kernel > taint. Everytime after prop_work is done we are also > giving up connector reference, which is resulting in ref > count underrun. > > Before scheduling prop_work acquire connector reference. I has been alreayd taken care at https://patchwork.freedesktop.org/patch/397215/?series=82998&rev=2 > > Cc: Sean Paul > Cc: Ramalingam C > Signed-off-by: Srinivas Kamati > --- > drivers/gpu/drm/i915/display/intel_hdcp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c > index b2a4bbcfdcd2..beedd672b21e 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdcp.c > +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c > @@ -2210,6 +2210,7 @@ void intel_hdcp_update_pipe(struct intel_atomic_state *state, > if (content_protection_type_changed) { > mutex_lock(&hdcp->mutex); > hdcp->value = DRM_MODE_CONTENT_PROTECTION_DESIRED; > + drm_connector_get(&connector->base); > schedule_work(&hdcp->prop_work); > mutex_unlock(&hdcp->mutex); > } > -- > 2.25.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx