From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A242FC4363A for ; Wed, 28 Oct 2020 20:18:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 335EC247E4 for ; Wed, 28 Oct 2020 20:18:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 335EC247E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 67F956E3D0; Wed, 28 Oct 2020 20:18:37 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0F5EA6E3D0 for ; Wed, 28 Oct 2020 20:18:35 +0000 (UTC) IronPort-SDR: uVgaA0vhCs+1W3l4ELUXEBfEMaeFTviJOAqKybjwLXtQfigexgw2VZGBsUr3rg1coTtyKXtO0d iPXyBGZ599SQ== X-IronPort-AV: E=McAfee;i="6000,8403,9788"; a="168460916" X-IronPort-AV: E=Sophos;i="5.77,427,1596524400"; d="scan'208";a="168460916" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 13:18:19 -0700 IronPort-SDR: O0QJzU+I9xFxg6png5ziMy8t8fIS629XJwCtIQw5EEezynsaspA/zKHyQeNSaHMCJVf/UjtI6N QFXeiTERjhpA== X-IronPort-AV: E=Sophos;i="5.77,427,1596524400"; d="scan'208";a="536374074" Received: from ideak-desk.fi.intel.com ([10.237.68.141]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Oct 2020 13:18:17 -0700 Date: Wed, 28 Oct 2020 22:18:14 +0200 From: Imre Deak To: Jason Andryuk Message-ID: <20201028201814.GE3693479@ideak-desk.fi.intel.com> References: <20201027133600.3656665-1-imre.deak@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix error handling during DPRX link training X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: imre.deak@intel.com Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Oct 27, 2020 at 10:02:45AM -0400, Jason Andryuk wrote: > On Tue, Oct 27, 2020 at 9:36 AM Imre Deak wrote: > > > > Make sure to propagate the error result from the DPRX link training > > phase. The lack of this broke the link training fall-back logic if the > > link training failed during the DPRX phase. > > > > Fixes: b30edfd8d0b4 ("drm/i915: Switch to LTTPR non-transparent mode li= nk training") > > References: https://gitlab.freedesktop.org/drm/intel/-/issues/1378 > > Reported-by: Jason Andryuk > > Cc: Ville Syrj=E4l=E4 > > Signed-off-by: Imre Deak > = > Reviewed-by: Jason Andryuk Thanks. > I haven't tested, but I assume this will cause my 7200 to fail link > training (channel equalization) and cause the flashing display. Any > suggestions there? Would a quirk like > https://lore.kernel.org/lkml/20201023124804.11457-1-jandryuk@gmail.com/ > be acceptable? I'd like to try finding the root cause, if you could provide some more logs on the gitlab ticket (will follow-up there). > = > Regards, > Jason _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx