From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97AF9C2D0A3 for ; Thu, 29 Oct 2020 16:09:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BCD02076D for ; Thu, 29 Oct 2020 16:09:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BCD02076D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3E5356E8C3; Thu, 29 Oct 2020 16:09:17 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9DAC06E8C3; Thu, 29 Oct 2020 16:09:16 +0000 (UTC) IronPort-SDR: GshIsFz7iXT2lx4YavL1l+YlrqKdK0DonX08zXtHmiIEmTJU1euglN/LeWbgHj5J7igKRtpYal N5+TUZfUYE2g== X-IronPort-AV: E=McAfee;i="6000,8403,9788"; a="165873838" X-IronPort-AV: E=Sophos;i="5.77,430,1596524400"; d="scan'208";a="165873838" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2020 09:09:15 -0700 IronPort-SDR: 6lHAkU2uMm9i+6B5nevJE3AdPH/wGl+0ItOdqeMRDuc1klGvub8wLCUkCz+geWYxLjJaCZPV8O er5kIXRwj3dw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,430,1596524400"; d="scan'208";a="362145339" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by orsmga007.jf.intel.com with SMTP; 29 Oct 2020 09:09:12 -0700 Received: by stinkbox (sSMTP sendmail emulation); Thu, 29 Oct 2020 18:09:12 +0200 Date: Thu, 29 Oct 2020 18:09:12 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Chris Wilson Message-ID: <20201029160912.GE6112@intel.com> References: <20201029110030.9959-1-chris@chris-wilson.co.uk> <20201029140746.GD6112@intel.com> <160398728309.7048.13594460258034679908@build.alporthouse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <160398728309.7048.13594460258034679908@build.alporthouse.com> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH] drm: Silence zero EDID carping X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Oct 29, 2020 at 04:01:23PM +0000, Chris Wilson wrote: > Quoting Ville Syrj=E4l=E4 (2020-10-29 14:07:46) > > On Thu, Oct 29, 2020 at 11:00:30AM +0000, Chris Wilson wrote: > > > We have a few displays in CI that always report their EDID as a bunch= of > > > zeroes. This is consistent behavioud, so one assumes intentional > > > indication of an "absent" EDID. Let us treat is as such by silently > > > reporting the zero edid using connector->null_edid_counter, leaving t= he > > > loud carp to EDID that violate their checksums or otherwise return > > > unexpected illegal data upon reading. These are more likely to be > > > inconsistent bad connections rather than being intended. > > = > > I don't think null_edid_counter is actually used by anything. > > So apart from wondering why the mode list has turned strange > > is there some way I can still see from the logs that the > > EDID has become all zeroes? > = > The ones in question, it's every time we read the EDID it comes back > zero. I am betting that transient everything-is-zero rather than > spurious data is rare enough not to worry about. > = > An alternative would be to pass the log level to the bad_edid dumper, or > just make it debug for even gibberish edids? I suspect debug should be good enough for this. The user is probably going to notice some problem with their display resolution if the EDID is bad/zero, so we should still get the bug report. -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx