From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DEBDC4363A for ; Fri, 30 Oct 2020 13:50:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CBA02076E for ; Fri, 30 Oct 2020 13:50:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CBA02076E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A42DF6E9BA; Fri, 30 Oct 2020 13:50:16 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 537CE6E9BA for ; Fri, 30 Oct 2020 13:50:15 +0000 (UTC) IronPort-SDR: q6C9Nm1ya7WknNbnXViMmMdVcG6QLw2UR3ohhH+csA+l5FqS+yct+d3Jq90XUol8F1RWJVkCAY OOQCok8gG0Sw== X-IronPort-AV: E=McAfee;i="6000,8403,9789"; a="166020969" X-IronPort-AV: E=Sophos;i="5.77,433,1596524400"; d="scan'208";a="166020969" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2020 06:50:14 -0700 IronPort-SDR: gePcNNnwiQ7zr8wuS0BdKEDCwqVvs8wNpublrTWHuXkKAnZq05mtgTrufVCUzVgEJgEsGsRD9t rKYx9Rmsx6Ow== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,433,1596524400"; d="scan'208";a="425349095" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga001.fm.intel.com with SMTP; 30 Oct 2020 06:50:12 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 30 Oct 2020 15:50:11 +0200 Date: Fri, 30 Oct 2020 15:50:11 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Lucas De Marchi Message-ID: <20201030135011.GI6112@intel.com> References: <20201028213323.5423-1-ville.syrjala@linux.intel.com> <20201028213323.5423-18-ville.syrjala@linux.intel.com> <20201028221657.lizjycr7kxwl274n@ldmartin-desk1> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201028221657.lizjycr7kxwl274n@ldmartin-desk1> X-Patchwork-Hint: comment User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH v3 17/19] drm/i915: Enable hpd logic only for ports that are present X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Oct 28, 2020 at 03:16:57PM -0700, Lucas De Marchi wrote: > On Wed, Oct 28, 2020 at 11:33:21PM +0200, Ville Syrj=E4l=E4 wrote: > >From: Ville Syrj=E4l=E4 > > > >Let's enable the hardware hpd logic only for the ports we > >can actually use. > > > >In theory this may save some miniscule amounts of power, > >and more importantly it eliminates a lot if platform specific > >codepaths since the generic thing can now deal with any > >combination of ports being present on each SKU. > > > >v2: Deal with DG1 > > > >Signed-off-by: Ville Syrj=E4l=E4 > = > = > Reviewed-by: Lucas De Marchi While applying I noticed that I fumbled the dg1 changes slightly. icp_ddi_hotplug_enables() was missing the HPD_PORT_D stuff. I fixed that up and pushed the lot. Thanks for the review. -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx