From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0832C2D0A3 for ; Wed, 4 Nov 2020 17:38:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DD812067D for ; Wed, 4 Nov 2020 17:38:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D8ncMu08" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DD812067D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DD00D6E217; Wed, 4 Nov 2020 17:38:26 +0000 (UTC) Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB87689E11; Wed, 4 Nov 2020 15:03:47 +0000 (UTC) Received: by mail-pf1-x442.google.com with SMTP id j18so17513728pfa.0; Wed, 04 Nov 2020 07:03:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition; bh=Cpcyf2os5AGZUKltjzw6mmvdqbBSobD8RORnek/XVyo=; b=D8ncMu08T1OvGeBwqUDALGzrifbn52YuhJiLosvBbOamy07+NM4aRofAi6wpZhFu7o h6+vsSgcuCac+V2pdkw8jQUXQO4fMMNMHJJYkr1bwJqmmZZICd+PzKySiGcaGb2iIoVr OBL0dalld+I48UA6Fx5fpYfVGzZ+KxU9rUqlwKfiRqWvuX2vZLeEDrl4vLNaHUYCvLhj DcCQXPJTYd0UjGjzrFXenLrwgbyNDEncChAJ31m+CXLgt6Kbx6vYJZa5FkLttq8S07Lk ySRi1mkBE+5tARxbwx6uKCIV9dFa2jCUNVrB2IpckikzQVS81JiZdJvQO7401/mfHR/8 vWPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition; bh=Cpcyf2os5AGZUKltjzw6mmvdqbBSobD8RORnek/XVyo=; b=p23rT2Qb9xRwV+9tNZsQRWlLbBRYdnBfdIFQEyAyWRh7VO6XSl0Np9mbJyNlInS/Qz hRbWUL4AuWPcJ914K20uDCWL4LHoooHz6u0+w6lw9gZ5ESXcdS2f0JRX+mCvRqvVvI1R U0mJhNXpR+qfB8ZXEqpXwLUaq8XZ9LvfCKfUuLKgBR0JGax0EBxGjtieLxiF/3IcLhpX /5+D5SWmtYZq5CtiM3Ul+cRpBqfMxu9I1zT46iFOOalI2nXSDdg2BErAtEeUoctQOdIT ld8QS1ShaJK+4XM0gil5gCGjjrnmJ6jOSxLKOZBmmkrHWR4eFt46bQBkl6FnvEMpTj55 Eq8A== X-Gm-Message-State: AOAM530nVpJdSW8BbFjvjEdJWL40NfGt6m0ZZgj7T6+ygXXum8AV/khb XL5XcHrJFeaMgwNFTpkGBPE= X-Google-Smtp-Source: ABdhPJwAnv8VuhxZLOh69pT/O6WNOFA7xnF9jPLzCeTgfTiii/Zr65gXy4oBF1C/+g76XjU5+oip1w== X-Received: by 2002:a17:90b:30d2:: with SMTP id hi18mr4834398pjb.186.1604502227223; Wed, 04 Nov 2020 07:03:47 -0800 (PST) Received: from localhost ([160.202.157.3]) by smtp.gmail.com with ESMTPSA id 21sm2831827pfv.122.2020.11.04.07.03.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Nov 2020 07:03:46 -0800 (PST) Date: Wed, 4 Nov 2020 20:33:39 +0530 From: Deepak R Varma To: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Message-ID: <20201104150339.GA68663@localhost> MIME-Version: 1.0 Content-Disposition: inline X-Mailman-Approved-At: Wed, 04 Nov 2020 17:38:25 +0000 Subject: [Intel-gfx] [PATCH] drm/i915/perf: replace idr_init() by idr_init_base() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mh12gx2825@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" idr_init() uses base 0 which is an invalid identifier. The new function idr_init_base allows IDR to set the ID lookup from base 1. This avoids all lookups that otherwise starts from 0 since 0 is always unused. References: commit 6ce711f27500 ("idr: Make 1-based IDRs more efficient") Signed-off-by: Deepak R Varma --- drivers/gpu/drm/i915/i915_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c index e94976976571..2d033255b7cf 100644 --- a/drivers/gpu/drm/i915/i915_perf.c +++ b/drivers/gpu/drm/i915/i915_perf.c @@ -4367,7 +4367,7 @@ void i915_perf_init(struct drm_i915_private *i915) RUNTIME_INFO(i915)->cs_timestamp_frequency_hz / 2; mutex_init(&perf->metrics_lock); - idr_init(&perf->metrics_idr); + idr_init_base(&perf->metrics_idr, 1); /* We set up some ratelimit state to potentially throttle any * _NOTES about spurious, invalid OA reports which we don't -- 2.25.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx