From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DDE5C2D0E4 for ; Thu, 12 Nov 2020 19:43:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95C0A20759 for ; Thu, 12 Nov 2020 19:43:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 95C0A20759 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CA9EC6E329; Thu, 12 Nov 2020 19:43:18 +0000 (UTC) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 34FA96E329 for ; Thu, 12 Nov 2020 19:43:18 +0000 (UTC) IronPort-SDR: bRkBKt/LeE1WzSdlsjSFHnea51+P3PCo1Ib2dP8Rk5mGxyM4sljlsX9VTadwl1u/uCUksDRXdU 6ziXL4RURL8Q== X-IronPort-AV: E=McAfee;i="6000,8403,9803"; a="166861547" X-IronPort-AV: E=Sophos;i="5.77,472,1596524400"; d="scan'208";a="166861547" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2020 11:42:59 -0800 IronPort-SDR: g+LYVb4CnTd9ModlQ4SdrGIJGp7fZjnrKkSkCUxTpwjMPxM6dAtTyJ7nTwS7/cGKuhcUSt2q+2 Y8Jjl2hiXO0Q== X-IronPort-AV: E=Sophos;i="5.77,472,1596524400"; d="scan'208";a="474396032" Received: from labuser-z97x-ud5h.jf.intel.com (HELO labuser-Z97X-UD5H) ([10.165.21.211]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Nov 2020 11:42:59 -0800 Date: Thu, 12 Nov 2020 11:45:21 -0800 From: "Navare, Manasi" To: Ville Syrjala Message-ID: <20201112194521.GA15399@labuser-Z97X-UD5H> References: <20201112191718.16683-1-ville.syrjala@linux.intel.com> <20201112191718.16683-2-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201112191718.16683-2-ville.syrjala@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [Intel-gfx] [PATCH 1/6] drm/i915: Move encoder->get_config to a new function X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, Nov 12, 2020 at 09:17:13PM +0200, Ville Syrjala wrote: > From: Manasi Navare > = > No functional changes, create a separate intel_encoder_get_config() > function that calls encoder->get_config hook. > This is needed so that later we can add beigjoienr related > readout here. bigjoiner misspelled Other than that Reviewed-by: Manasi Navare Manasi > = > Signed-off-by: Manasi Navare > [vsyrjala: Move the code around for the future] > Signed-off-by: Ville Syrj=E4l=E4 > --- > drivers/gpu/drm/i915/display/intel_display.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > = > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/d= rm/i915/display/intel_display.c > index 9566a8d1f470..110d08f2a5c5 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -8141,6 +8141,12 @@ static void intel_crtc_compute_pixel_rate(struct i= ntel_crtc_state *crtc_state) > ilk_pipe_pixel_rate(crtc_state); > } > = > +static void intel_encoder_get_config(struct intel_encoder *encoder, > + struct intel_crtc_state *crtc_state) > +{ > + encoder->get_config(encoder, crtc_state); > +} > + > static int intel_crtc_compute_config(struct intel_crtc *crtc, > struct intel_crtc_state *pipe_config) > { > @@ -12403,7 +12409,7 @@ intel_encoder_current_mode(struct intel_encoder *= encoder) > return NULL; > } > = > - encoder->get_config(encoder, crtc_state); > + intel_encoder_get_config(encoder, crtc_state); > = > intel_mode_from_pipe_config(mode, crtc_state); > = > @@ -14448,7 +14454,7 @@ verify_crtc_state(struct intel_crtc *crtc, > pipe_name(pipe)); > = > if (active) > - encoder->get_config(encoder, pipe_config); > + intel_encoder_get_config(encoder, pipe_config); > } > = > intel_crtc_compute_pixel_rate(pipe_config); > @@ -18761,7 +18767,7 @@ static void intel_modeset_readout_hw_state(struct= drm_device *dev) > crtc_state =3D to_intel_crtc_state(crtc->base.state); > = > encoder->base.crtc =3D &crtc->base; > - encoder->get_config(encoder, crtc_state); > + intel_encoder_get_config(encoder, crtc_state); > if (encoder->sync_state) > encoder->sync_state(encoder, crtc_state); > } else { > -- = > 2.26.2 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx