From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E610CC388F9 for ; Mon, 16 Nov 2020 23:35:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7A9142223C for ; Mon, 16 Nov 2020 23:35:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7A9142223C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B70856E087; Mon, 16 Nov 2020 23:35:09 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 91C316E087 for ; Mon, 16 Nov 2020 23:35:08 +0000 (UTC) IronPort-SDR: BkqBGdCcFFJlyi2YTjIV/tu0W2KuiamvH4Oo9rBppel81yguda8QNO4EgmFClczOiuz3qPO9hF RumG2zZkbtdA== X-IronPort-AV: E=McAfee;i="6000,8403,9807"; a="168256126" X-IronPort-AV: E=Sophos;i="5.77,483,1596524400"; d="scan'208";a="168256126" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2020 15:35:03 -0800 IronPort-SDR: cH9pGfguQa9CU9pW/Z2l1eViqFMGrvOpIGBI7EJXIqFlzA/Pq7EHlBDZonhD7TDXdR+eDY5FEt CQRyrUjPTKqg== X-IronPort-AV: E=Sophos;i="5.77,483,1596524400"; d="scan'208";a="310547237" Received: from labuser-z97x-ud5h.jf.intel.com (HELO labuser-Z97X-UD5H) ([10.165.21.211]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2020 15:35:02 -0800 Date: Mon, 16 Nov 2020 15:37:32 -0800 From: "Navare, Manasi" To: Ville Syrjala Message-ID: <20201116233731.GA29169@labuser-Z97X-UD5H> References: <20201113220358.24794-1-ville.syrjala@linux.intel.com> <20201113220358.24794-16-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201113220358.24794-16-ville.syrjala@linux.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [Intel-gfx] [PATCH 15/23] drm/i915: Add crtcs affected by bigjoiner to the state X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sat, Nov 14, 2020 at 12:03:50AM +0200, Ville Syrjala wrote: > From: Ville Syrj=E4l=E4 > = > Make sure both crtcs participating in the bigjoiner stuff > are in the state. > = > Signed-off-by: Ville Syrj=E4l=E4 Reviewed-by: Manasi Navare Manasi > --- > drivers/gpu/drm/i915/display/intel_display.c | 25 ++++++++++++++++++++ > 1 file changed, 25 insertions(+) > = > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/d= rm/i915/display/intel_display.c > index 07bee5caacfe..465877097582 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -15422,6 +15422,27 @@ static int intel_atomic_check_async(struct intel= _atomic_state *state) > return 0; > } > = > +static int intel_bigjoiner_add_affected_crtcs(struct intel_atomic_state = *state) > +{ > + const struct intel_crtc_state *crtc_state; > + struct intel_crtc *crtc; > + int i; > + > + for_each_new_intel_crtc_in_state(state, crtc, crtc_state, i) { > + struct intel_crtc_state *linked_crtc_state; > + > + if (!crtc_state->bigjoiner) > + continue; > + > + linked_crtc_state =3D intel_atomic_get_crtc_state(&state->base, > + crtc_state->bigjoiner_linked_crtc); > + if (IS_ERR(linked_crtc_state)) > + return PTR_ERR(linked_crtc_state); > + } > + > + return 0; > +} > + > /** > * intel_atomic_check - validate state object > * @dev: drm device > @@ -15447,6 +15468,10 @@ static int intel_atomic_check(struct drm_device = *dev, > if (ret) > goto fail; > = > + ret =3D intel_bigjoiner_add_affected_crtcs(state); > + if (ret) > + goto fail; > + > for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state, > new_crtc_state, i) { > if (!needs_modeset(new_crtc_state)) { > -- = > 2.26.2 > = > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx