From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5761AC83017 for ; Tue, 1 Dec 2020 21:31:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EAE132084C for ; Tue, 1 Dec 2020 21:31:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EAE132084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 35E5F6E928; Tue, 1 Dec 2020 21:31:20 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 017B86E928 for ; Tue, 1 Dec 2020 21:31:18 +0000 (UTC) IronPort-SDR: eHyeBFx2jzOnsc1AUcsQr0t1FA9k881bUoH7Avk+Jw+ZlTEvAY725rumvgARxHRLoatLPuj5z/ TKw77BniHJMw== X-IronPort-AV: E=McAfee;i="6000,8403,9822"; a="173069958" X-IronPort-AV: E=Sophos;i="5.78,385,1599548400"; d="scan'208";a="173069958" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2020 13:31:16 -0800 IronPort-SDR: LdOcyL+QRHfWFLVX3N17c3ZUqlUEUs5GwiInojCZZoCgfgCvzL70d67eJR5nDf9vzY5lzCGAIm Hx2bYyQFYP/Q== X-IronPort-AV: E=Sophos;i="5.78,385,1599548400"; d="scan'208";a="335274488" Received: from ideak-desk.fi.intel.com ([10.237.68.141]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Dec 2020 13:31:14 -0800 Date: Tue, 1 Dec 2020 23:31:09 +0200 From: Imre Deak To: Chris Wilson Message-ID: <20201201213109.GA2934188@ideak-desk.fi.intel.com> References: <20201123182631.1740781-1-imre.deak@intel.com> <20201123182631.1740781-2-imre.deak@intel.com> <160682607520.4024.5213539229190522123@build.alporthouse.com> <20201201205021.GD2849269@ideak-desk.fi.intel.com> <160685704629.19969.3005909283019006262@build.alporthouse.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <160685704629.19969.3005909283019006262@build.alporthouse.com> Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/tgl: Add Clear Color support for TGL Render Decompression X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: imre.deak@intel.com Cc: Nanley G Chery , Rafael Antognolli , intel-gfx@lists.freedesktop.org, Dhinakaran Pandiyan , Ville Syrjala , Shashank Sharma Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Dec 01, 2020 at 09:10:46PM +0000, Chris Wilson wrote: > Quoting Imre Deak (2020-12-01 20:50:21) > > On Tue, Dec 01, 2020 at 12:34:35PM +0000, Chris Wilson wrote: > > > There's also the matter of coherency. Is the object coherent for reads > > > from the CPU? -- in most cases it will not be, but you should check > > > obj->cache_coherency to see if the read requires a preceding > > > cache_clflush_range() / drm_clflush_virt_range(). > > > > Ok, at this point for the TGL-only modifier, we could then just > > warn_on(!bo_cache_coherent_for_read) due to HAS_LLC. > > Stupid question, is the same path required for dg1? > > That makes everything more difficult as the struct pages are gone. Yes, same path. So we do need a different way to map. --Imre _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx