From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06262C433FE for ; Mon, 7 Dec 2020 13:59:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AA4FC235DD for ; Mon, 7 Dec 2020 13:58:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AA4FC235DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 297F86E847; Mon, 7 Dec 2020 13:58:59 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id B4B1C6E847 for ; Mon, 7 Dec 2020 13:58:57 +0000 (UTC) IronPort-SDR: OUobNl3/BSkoOdxxVyIgJJVs0ReWXkrIeRIoW0OA3kSZTz79t24+AIbY4DMwpqDVZnxI0AAajT dm57kUbHBkIA== X-IronPort-AV: E=McAfee;i="6000,8403,9827"; a="191973167" X-IronPort-AV: E=Sophos;i="5.78,399,1599548400"; d="scan'208";a="191973167" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2020 05:58:57 -0800 IronPort-SDR: 5D1Vx+lNS3TeEz6EfQEZAu8I+uk4PhhhGVzrmUgsGYYp/76NzJYA8aRTdFKWaU5ZkfUWnvVcHz +Ygd5amHu6bQ== X-IronPort-AV: E=Sophos;i="5.78,399,1599548400"; d="scan'208";a="332104569" Received: from ramaling-i9x.iind.intel.com (HELO intel.com) ([10.99.66.154]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2020 05:58:55 -0800 Date: Mon, 7 Dec 2020 19:28:40 +0530 From: Ramalingam C To: Chris Wilson Message-ID: <20201207135840.GC26545@intel.com> References: <20201207130201.8492-1-chris@chris-wilson.co.uk> <20201207130346.11849-1-chris@chris-wilson.co.uk> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201207130346.11849-1-chris@chris-wilson.co.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Improve error reporting for igt_mock_max_segment X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Matthew Auld Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 2020-12-07 at 13:03:46 +0000, Chris Wilson wrote: > When we fail to find a single block large enough to require splitting, > report the largest block we did find. > > Signed-off-by: Chris Wilson > Cc: Matthew Auld > Cc: Ramalingam C > --- > .../gpu/drm/i915/selftests/intel_memory_region.c | 15 +++++++-------- > 1 file changed, 7 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/selftests/intel_memory_region.c b/drivers/gpu/drm/i915/selftests/intel_memory_region.c > index a0b518c255de..a55079a061dd 100644 > --- a/drivers/gpu/drm/i915/selftests/intel_memory_region.c > +++ b/drivers/gpu/drm/i915/selftests/intel_memory_region.c > @@ -384,16 +384,15 @@ static int igt_mock_max_segment(void *arg) > goto out_put; > } > > - err = -EINVAL; > + size = 0; > list_for_each_entry(block, &obj->mm.blocks, link) { > - if (i915_buddy_block_size(&mem->mm, block) > max_segment) { > - err = 0; > - break; > - } > + if (i915_buddy_block_size(&mem->mm, block) > size) > + size = i915_buddy_block_size(&mem->mm, block); > } > - if (err) { > - pr_err("%s: Failed to create a huge contiguous block\n", > - __func__); > + if (size < max_segment) { > + pr_err("%s: Failed to create a huge contiguous block [> %u], largest block %lld\n", > + __func__, max_segment, size); > + err = -EINVAL; Reviewed-by: Ramalingam C > goto out_close; > } > > -- > 2.20.1 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx