From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BA65C433ED for ; Mon, 26 Apr 2021 14:19:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 604AD6101B for ; Mon, 26 Apr 2021 14:19:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 604AD6101B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C73A389E14; Mon, 26 Apr 2021 14:19:15 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1629889E14; Mon, 26 Apr 2021 14:19:15 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id D12DF68C4E; Mon, 26 Apr 2021 16:19:11 +0200 (CEST) Date: Mon, 26 Apr 2021 16:19:11 +0200 From: Christoph Hellwig To: Jason Gunthorpe Message-ID: <20210426141911.GH15209@lst.de> References: <0-v1-d88406ed308e+418-vfio3_jgg@nvidia.com> <10-v1-d88406ed308e+418-vfio3_jgg@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <10-v1-d88406ed308e+418-vfio3_jgg@nvidia.com> User-Agent: Mutt/1.5.17 (2007-11-01) Subject: Re: [Intel-gfx] [PATCH 10/12] vfio/mdev: Remove mdev_parent_ops X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, linux-doc@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org, Kirti Wankhede , Vineeth Vijayan , Leon Romanovsky , Christoph Hellwig , linux-s390@vger.kernel.org, "Raj, Ashok" , Jonathan Corbet , Halil Pasic , Christian Borntraeger , Tarun Gupta , intel-gfx@lists.freedesktop.org, Max Gurtovoy , Eric Farman , Vasily Gorbik , Heiko Carstens , Harald Freudenberger , Dan Williams , intel-gvt-dev@lists.freedesktop.org, Tony Krowiak , Pierre Morel , Cornelia Huck , Peter Oberparleiter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" > +The mediated bus driver's probe function should create a vfio_device on top of > +the mdev_device and connect it to an appropriate implementation of vfio_device_ops. Overly long line. > +This will provide the 'mdev_supported_types/XX/create' files which can then be used > +to trigger the creation of a mdev_device. The created mdev_device will be attached Two more. Otherwise looks good: Reviewed-by: Christoph Hellwig _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx