From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78B1CC433B4 for ; Wed, 19 May 2021 00:59:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 30D566108D for ; Wed, 19 May 2021 00:59:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 30D566108D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 83A446ECC6; Wed, 19 May 2021 00:59:26 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 985676ECB6; Wed, 19 May 2021 00:59:24 +0000 (UTC) IronPort-SDR: zdpdcVncITMZ83RE+mdMiCvY+KGP5IACscnFMcf6zddiS4FSFEzCB0fcUX12zXXaGmZMYIOf21 aO0ktaje+iVg== X-IronPort-AV: E=McAfee;i="6200,9189,9988"; a="198907150" X-IronPort-AV: E=Sophos;i="5.82,310,1613462400"; d="asc'?scan'208";a="198907150" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2021 17:59:24 -0700 IronPort-SDR: ZFNJ9v34KyZjQJ7nCbHzT5pveXBRaduyRWjC7Ze6IW4PnyhTW0DGIz7gDmzXQw63WrjvY/ozdB CXgUXaIT8E5A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,310,1613462400"; d="asc'?scan'208";a="461017066" Received: from zhen-hp.sh.intel.com (HELO zhen-hp) ([10.239.160.147]) by fmsmga004.fm.intel.com with ESMTP; 18 May 2021 17:59:21 -0700 Date: Wed, 19 May 2021 08:40:12 +0800 From: Zhenyu Wang To: Greg Kroah-Hartman Message-ID: <20210519004012.GF4589@zhen-hp.sh.intel.com> References: <20210518161705.3697143-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 In-Reply-To: <20210518161705.3697143-1-gregkh@linuxfoundation.org> Subject: Re: [Intel-gfx] [PATCH] drm/i915/gvt: remove local storage of debugfs file X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Zhenyu Wang Cc: David Airlie , dri-devel@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org Content-Type: multipart/mixed; boundary="===============1964262550==" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" --===============1964262550== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="WRT3RXLOp/bBMgTI" Content-Disposition: inline --WRT3RXLOp/bBMgTI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2021.05.18 18:17:05 +0200, Greg Kroah-Hartman wrote: > There is no need to keep the dentry around for the debugfs kvmgt cache > file, as we can just look it up when we want to remove it later on. > Simplify the structure by removing the dentry and relying on debugfs > to find the dentry to remove when we want to. >=20 > By doing this change, we remove the last in-kernel user that was storing > the result of debugfs_create_long(), so that api can be cleaned up. >=20 > Cc: Zhenyu Wang > Cc: Zhi Wang > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: David Airlie > Cc: Daniel Vetter > Cc: intel-gvt-dev@lists.freedesktop.org > Cc: intel-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Greg Kroah-Hartman > --- > drivers/gpu/drm/i915/gvt/kvmgt.c | 11 +++++------ > 1 file changed, 5 insertions(+), 6 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/= kvmgt.c > index 65ff43cfc0f7..433c2a448f2d 100644 > --- a/drivers/gpu/drm/i915/gvt/kvmgt.c > +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c > @@ -88,6 +88,7 @@ struct kvmgt_pgfn { > struct hlist_node hnode; > }; > =20 > +#define KVMGT_DEBUGFS_FILENAME "kvmgt_nr_cache_entries" > struct kvmgt_guest_info { > struct kvm *kvm; > struct intel_vgpu *vgpu; > @@ -95,7 +96,6 @@ struct kvmgt_guest_info { > #define NR_BKT (1 << 18) > struct hlist_head ptable[NR_BKT]; > #undef NR_BKT > - struct dentry *debugfs_cache_entries; > }; > =20 > struct gvt_dma { > @@ -1843,16 +1843,15 @@ static int kvmgt_guest_init(struct mdev_device *m= dev) > info->track_node.track_flush_slot =3D kvmgt_page_track_flush_slot; > kvm_page_track_register_notifier(kvm, &info->track_node); > =20 > - info->debugfs_cache_entries =3D debugfs_create_ulong( > - "kvmgt_nr_cache_entries", > - 0444, vgpu->debugfs, > - &vdev->nr_cache_entries); > + debugfs_create_ulong(KVMGT_DEBUGFS_FILENAME, 0444, vgpu->debugfs, > + &vdev->nr_cache_entries); > return 0; > } > =20 > static bool kvmgt_guest_exit(struct kvmgt_guest_info *info) > { > - debugfs_remove(info->debugfs_cache_entries); > + debugfs_remove(debugfs_lookup(KVMGT_DEBUGFS_FILENAME, > + info->vgpu->debugfs)); > =20 > kvm_page_track_unregister_notifier(info->kvm, &info->track_node); > kvm_put_kvm(info->kvm); > --=20 Reviewed-by: Zhenyu Wang Thanks! --WRT3RXLOp/bBMgTI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EARECAB0WIQTXuabgHDW6LPt9CICxBBozTXgYJwUCYKReZQAKCRCxBBozTXgY JwTEAKCDGxm/Bg4Px7VakIDfjEMhT+c5+QCfRp0gD/H6l4GaSyK+9Khgoa1vDk8= =1eoh -----END PGP SIGNATURE----- --WRT3RXLOp/bBMgTI-- --===============1964262550== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1964262550==--