From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF304C2B9F8 for ; Tue, 25 May 2021 15:20:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A43C06113B for ; Tue, 25 May 2021 15:20:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A43C06113B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 32CA96E07F; Tue, 25 May 2021 15:20:01 +0000 (UTC) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 514F96E07F for ; Tue, 25 May 2021 15:19:59 +0000 (UTC) IronPort-SDR: ootNCbcv0Pc06uklj55xOb8KhObTxLI8cKpdENqVgk7JYrSweeCkNjw8balIbLHb18x6lK7q08 EUAaIvD+rJGQ== X-IronPort-AV: E=McAfee;i="6200,9189,9995"; a="189340142" X-IronPort-AV: E=Sophos;i="5.82,328,1613462400"; d="scan'208";a="189340142" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2021 08:19:56 -0700 IronPort-SDR: 8x7ISc83zP5PXvRMrcYD/W1IRg4MxTStlSuuuRsDpuvktbdo4sTj9bdWSWeyyiLr+Wgi4jTZNG cpKmImisK7tA== X-IronPort-AV: E=Sophos;i="5.82,328,1613462400"; d="scan'208";a="546816432" Received: from ideak-desk.fi.intel.com ([10.237.68.141]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2021 08:19:54 -0700 Date: Tue, 25 May 2021 18:19:50 +0300 From: Imre Deak To: Matthew Auld Message-ID: <20210525151950.GA2361902@ideak-desk.fi.intel.com> References: <20210507091210.371132-1-matthew.auld@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: relax 2big checking around initial fb X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development , Matthew Auld , Chris Wilson Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, May 25, 2021 at 02:25:15PM +0100, Matthew Auld wrote: > On Fri, 7 May 2021 at 10:12, Matthew Auld wrote: > > > > From: Chris Wilson > > > > The kernel prefers enabling fbc over the initial fb, since this leads to > > actual runtime power savings, so if the initial fb is deemed too big > > using some heuristic, then we simply skip allocating stolen for it. > > However if the kernel is not configured with fbcon then it should be > > possible to relax this, since unlike with fbcon the display server > > shouldn't preserve it when later replacing it, and so we should be able > > to re-use the stolen memory for fbc and friends. This patch is reported > > to fix some flicker seen during boot splash on some devices. > > > > Signed-off-by: Chris Wilson > > Signed-off-by: Matthew Auld > > Cc: Lee Shawn C > > Cc: Ville Syrj=E4l=E4 > > Cc: Daniel Vetter > = > Ville, Imre, or somebody else with display experience, does this at > least look somewhat reasonable? > = > > --- > > drivers/gpu/drm/i915/display/intel_display.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu= /drm/i915/display/intel_display.c > > index ec2d3fa60003..0ee1f0213fd9 100644 > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > @@ -1455,7 +1455,7 @@ initial_plane_vma(struct drm_i915_private *i915, > > * important and we should probably use that space with FBC or = other > > * features. > > */ > > - if (size * 2 > i915->stolen_usable_size) > > + if (IS_ENABLED(FRAMEBUFFER_CONSOLE) && size * 2 > i915->stolen_= usable_size) Makes sense and aligns with how the FB object is allocated in intelfb_alloc= (): Reviewed-by: Imre Deak > > return NULL; > > > > obj =3D i915_gem_object_create_stolen_for_preallocated(i915, ba= se, size); > > -- > > 2.26.3 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx