Re: [Intel-gfx] [PATCH] drm/i915/ttm: fix static warning

Thomas Hellström
2021-06-23T15:24:27Z

On 6/23/21 4:34 PM, Matthew Auld wrote:
> warning: symbol 'i915_gem_ttm_obj_ops' was not declared. Should it be static?
>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> index c5deb8b7227c..cf5540c1537b 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> @@ -730,7 +730,7 @@ static u64 i915_ttm_mmap_offset(struct drm_i915_gem_object *obj)
> return drm_vma_node_offset_addr(&obj->base.vma_node);
> }
>
> -const struct drm_i915_gem_object_ops i915_gem_ttm_obj_ops = {
> +static const struct drm_i915_gem_object_ops i915_gem_ttm_obj_ops = {
> .name = "i915_gem_object_ttm",
> .flags = I915_GEM_OBJECT_HAS_IOMEM,
>

Reviewed-by: Thomas Hellström <thellstrom@linux.intel.com>