From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D84E7C11F66 for ; Tue, 29 Jun 2021 08:51:20 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9E2A261DC1 for ; Tue, 29 Jun 2021 08:51:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9E2A261DC1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4857C6E830; Tue, 29 Jun 2021 08:51:20 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id B2D676E830 for ; Tue, 29 Jun 2021 08:51:19 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10029"; a="187797053" X-IronPort-AV: E=Sophos;i="5.83,308,1616482800"; d="scan'208";a="187797053" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2021 01:51:18 -0700 X-IronPort-AV: E=Sophos;i="5.83,308,1616482800"; d="scan'208";a="625560112" Received: from ramaling-i9x.iind.intel.com (HELO intel.com) ([10.99.66.205]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2021 01:51:16 -0700 Date: Tue, 29 Jun 2021 14:22:51 +0530 From: Ramalingam C To: Bommu Krishnaiah Message-ID: <20210629085251.GB29108@intel.com> References: <20210628143829.22995-1-krishnaiah.bommu@intel.com> <20210628143829.22995-5-krishnaiah.bommu@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210628143829.22995-5-krishnaiah.bommu@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH 4/4] Klock work Fix for uninitialized array intel_migrate.c X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Chris Wilson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 2021-06-28 at 20:08:29 +0530, Bommu Krishnaiah wrote: > Signed-off-by: Bommu Krishnaiah > Cc: Chris Wilson > --- > drivers/gpu/drm/i915/gt/intel_migrate.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/intel_migrate.c b/drivers/gpu/drm/i915/gt/intel_migrate.c > index 23c59ce66cee5..5df7b8af6fdb9 100644 > --- a/drivers/gpu/drm/i915/gt/intel_migrate.c > +++ b/drivers/gpu/drm/i915/gt/intel_migrate.c > @@ -208,11 +208,15 @@ static struct intel_context *__migrate_engines(struct intel_gt *gt) > > count = 0; > for (i = 0; i < ARRAY_SIZE(gt->engine_class[COPY_ENGINE_CLASS]); i++) { > + > engine = gt->engine_class[COPY_ENGINE_CLASS][i]; > if (engine_supports_migration(engine)) > engines[count++] = engine; > } > > + if (count == 0) > + return ERR_PTR(-ENXIO); > + > return intel_context_create(engines[random_index(count)]); This Kclockwork warning/error is false positive. As intel_migrate_copy->intel_migrate_create_context->__migrate_engines is called after the checkfor valid m->context which is created for first copy engine. So atleast one blitter is assured. hence we can ignore this Kclockwork result. Ram. > } > > -- > 2.25.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx