From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F33FC07E96 for ; Tue, 6 Jul 2021 09:38:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E52461993 for ; Tue, 6 Jul 2021 09:38:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E52461993 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C37E889D79; Tue, 6 Jul 2021 09:38:19 +0000 (UTC) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8AD258985A; Tue, 6 Jul 2021 09:38:18 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10036"; a="208904676" X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="208904676" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 02:38:18 -0700 X-IronPort-AV: E=Sophos;i="5.83,328,1616482800"; d="scan'208";a="647241989" Received: from ramaling-i9x.iind.intel.com (HELO intel.com) ([10.99.66.205]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 02:38:16 -0700 Date: Tue, 6 Jul 2021 15:09:55 +0530 From: Ramalingam C To: Matthew Auld Message-ID: <20210706093955.GA23963@intel.com> References: <20210702104642.1189978-1-matthew.auld@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210702104642.1189978-1-matthew.auld@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/selftests: fix smatch warning in igt_check_blocks X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Dan Carpenter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 2021-07-02 at 11:46:41 +0100, Matthew Auld wrote: > The block here can't be NULL, especially since we already dereferenced > it earlier, so remove the redundant check. > > igt_check_blocks() warn: variable dereferenced before check 'block' (see line 126) > > Reported-by: Dan Carpenter > Signed-off-by: Matthew Auld > --- > drivers/gpu/drm/i915/selftests/i915_buddy.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_buddy.c b/drivers/gpu/drm/i915/selftests/i915_buddy.c > index f0f5c4df8dbc..d61ec9c951bf 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_buddy.c > +++ b/drivers/gpu/drm/i915/selftests/i915_buddy.c > @@ -166,10 +166,8 @@ static int igt_check_blocks(struct i915_buddy_mm *mm, > igt_dump_block(mm, prev); > } > > - if (block) { > - pr_err("bad block, dump:\n"); > - igt_dump_block(mm, block); > - } > + pr_err("bad block, dump:\n"); > + igt_dump_block(mm, block); LGTM. Reviewed-by: Ramalingam C > > return err; > } > -- > 2.26.3 > _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx