Re: [Intel-gfx] [PATCH 20/27] drm/i915/guc: Connect UAPI to GuC multi-lrc interface

kernel test robot
2021-08-29T20:00:12Z

[-- Attachment #1: Type: text/plain, Size: 4120 bytes --]

Hi Matthew,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next next-20210827]
[cannot apply to tegra-drm/drm/tegra/for-next linus/master drm/drm-next v5.14-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Matthew-Brost/Parallel-submission-aka-multi-bb-execbuf/20210821-065348
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-rhel-8.3-kselftests (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-348-gf0e6938b-dirty
# https://github.com/0day-ci/linux/commit/0741c4627df7b17e3e1b06c5967aed4371c688f7
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Matthew-Brost/Parallel-submission-aka-multi-bb-execbuf/20210821-065348
git checkout 0741c4627df7b17e3e1b06c5967aed4371c688f7
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

sparse warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/i915/gem/i915_gem_context.c:1411:26: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct i915_gem_engines *e @@ got struct i915_gem_engines [noderef] __rcu *engines @@
drivers/gpu/drm/i915/gem/i915_gem_context.c:1411:26: sparse: expected struct i915_gem_engines *e
drivers/gpu/drm/i915/gem/i915_gem_context.c:1411:26: sparse: got struct i915_gem_engines [noderef] __rcu *engines
drivers/gpu/drm/i915/gem/i915_gem_context.c:1626:34: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected struct i915_address_space *vm @@ got struct i915_address_space [noderef] __rcu *vm @@
drivers/gpu/drm/i915/gem/i915_gem_context.c:1626:34: sparse: expected struct i915_address_space *vm
drivers/gpu/drm/i915/gem/i915_gem_context.c:1626:34: sparse: got struct i915_address_space [noderef] __rcu *vm

vim +1411 drivers/gpu/drm/i915/gem/i915_gem_context.c

1404
1405 static void context_close(struct i915_gem_context *ctx)
1406 {
1407 struct i915_address_space *vm;
1408
1409 /* Flush any concurrent set_engines() */
1410 mutex_lock(&ctx->engines_mutex);
> 1411 unpin_engines(ctx->engines);
1412 engines_idle_release(ctx, rcu_replace_pointer(ctx->engines, NULL, 1));
1413 i915_gem_context_set_closed(ctx);
1414 mutex_unlock(&ctx->engines_mutex);
1415
1416 mutex_lock(&ctx->mutex);
1417
1418 set_closed_name(ctx);
1419
1420 vm = i915_gem_context_vm(ctx);
1421 if (vm)
1422 i915_vm_close(vm);
1423
1424 if (ctx->syncobj)
1425 drm_syncobj_put(ctx->syncobj);
1426
1427 ctx->file_priv = ERR_PTR(-EBADF);
1428
1429 /*
1430 * The LUT uses the VMA as a backpointer to unref the object,
1431 * so we need to clear the LUT before we close all the VMA (inside
1432 * the ppgtt).
1433 */
1434 lut_close(ctx);
1435
1436 spin_lock(&ctx->i915->gem.contexts.lock);
1437 list_del(&ctx->link);
1438 spin_unlock(&ctx->i915->gem.contexts.lock);
1439
1440 mutex_unlock(&ctx->mutex);
1441
1442 /*
1443 * If the user has disabled hangchecking, we can not be sure that
1444 * the batches will ever complete after the context is closed,
1445 * keeping the context and all resources pinned forever. So in this
1446 * case we opt to forcibly kill off all remaining requests on
1447 * context close.
1448 */
1449 kill_context(ctx);
1450
1451 i915_gem_context_put(ctx);
1452 }
1453

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 42173 bytes --]