From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42DA0C432BE for ; Mon, 30 Aug 2021 06:45:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E989B60F56 for ; Mon, 30 Aug 2021 06:45:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E989B60F56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4DE7A89CDB; Mon, 30 Aug 2021 06:45:29 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 86BB289CDB for ; Mon, 30 Aug 2021 06:45:28 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10091"; a="281935734" X-IronPort-AV: E=Sophos;i="5.84,362,1620716400"; d="scan'208";a="281935734" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2021 23:45:27 -0700 X-IronPort-AV: E=Sophos;i="5.84,362,1620716400"; d="scan'208";a="540217351" Received: from ideak-desk.fi.intel.com ([10.237.68.141]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Aug 2021 23:45:25 -0700 Date: Mon, 30 Aug 2021 09:45:22 +0300 From: Imre Deak To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: "Lee, Shawn C" , "Almahallawy, Khaled" , "intel-gfx@lists.freedesktop.org" , "Chiou, Cooper" , "Tseng, William" Message-ID: <20210830064522.GA3420065@ideak-desk.fi.intel.com> References: <20210706152541.25021-1-shawn.c.lee@intel.com> <20210818161712.GA2831921@ideak-desk.fi.intel.com> <20210820230203.GC2886701@ideak-desk.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210820230203.GC2886701@ideak-desk.fi.intel.com> Subject: Re: [Intel-gfx] [PATCH] drm/i915/dp: return proper DPRX link training result X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sat, Aug 21, 2021 at 02:02:03AM +0300, Imre Deak wrote: > On Sat, Aug 21, 2021 at 01:20:04AM +0300, Ville Syrjälä wrote: > > On Wed, Aug 18, 2021 at 07:17:12PM +0300, Imre Deak wrote: > > > On Wed, Aug 18, 2021 at 06:09:43PM +0300, Lee, Shawn C wrote: > > > > On Tue, 2021-07-07, Lee Shawn C wrote: > > > > >On Tue, 2021-07-07, Almahallawy, Khaled wrote: > > > > >>I believe Imre's LT fallback: > > > > >>https://github.com/ideak/linux/commits/linktraining-fallback-fix and Chrome user space fix: > > > > >>https://chromium-review.googlesource.com/c/chromium/src/+/3003487 > > > > >>should address Chrome concerns for LT failure and LTTPRs > > > > >> > > > > > > > > > >Thanks for comment! The new fallback patch should help on this DPRX problem. > > > > >One more thing. If driver did not handle DPRX link train failed properly. > > > > >It would impact link layer compliance test case in below. > > > > > > > > > >400.3.1.3 > > > > >400.3.1.4 > > > > >400.3.1.6 > > > > >400.3.1.12 > > > > >400.3.1.13 > > > > >400.3.1.14 > > > > > > > > > >Best regards, > > > > >Shawn > > > > > > > > > > > > > Hi all, before Imre's patch series land on upstream driver. The link train failed > > > > handling works for LTTPR only. But DPRX does not. Could you please consider to have > > > > this change as temporary solution? Thanks! > > > > > > I sent already fixing this, see > > > https://lore.kernel.org/intel-gfx/20201027133600.3656665-1-imre.deak@intel.com/ > > > > > > but it fell through the cracks. Applied now your patch, thanks. > > > > We seem to have a tgl that fails consistently at DPRX link training: > > https://intel-gfx-ci.01.org/tree/drm-tip/fi-tgl-1115g4.html > > > > Previously the error went unnoticed. > > Yea, didn't notice this. Can't see anything obvious, besides that it's a > DPCD rev 1.1 monitor, so maybe not compatible with LTTPRs. I follow up > if I find something. Power cycling the machine and replugging the monitor and Type C dongle and native DP cable fixed it. So, it could be a flaky connection (unlikely, because detection worked), or the port in a stuck state even across warm-reboots. The latter would mean the machine wasn't power cycled for a long time and that's likely because the pstore kernel didn't boot (grub failed to load it due to a missing initrd). One possibile root cause is the TypeC PHY getting stuck across warm reboots issue (and nothing recovering it besides a power-cycle), that was fixed by 151ec347b06a2fb ("drm/i915: Force a TypeC PHY disconnect during suspend/shutdown") I'll re-check this after more CI testruns. > > -- > > Ville Syrjälä > > Intel