Re: [Intel-gfx] [PATCH v2 13/13] drm/msm: Implement HDCP 1.x using the new drm HDCP helpers

kernel test robot
2021-09-17T04:31:18Z

[-- Attachment #1: Type: text/plain, Size: 2891 bytes --]

Hi Sean,

I love your patch! Yet something to improve:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip next-20210916]
[cannot apply to robh/for-next linus/master v5.15-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Sean-Paul/drm-hdcp-Pull-HDCP-auth-exchange-check-into-helpers/20210916-044145
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/2fc7bb157fc24840f3fe3b8ece82cea21ded8db6
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sean-Paul/drm-hdcp-Pull-HDCP-auth-exchange-check-into-helpers/20210916-044145
git checkout 2fc7bb157fc24840f3fe3b8ece82cea21ded8db6
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arm

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/gpu/drm/msm/dp/dp_debug.c: In function 'dp_hdcp_key_write':
>> drivers/gpu/drm/msm/dp/dp_debug.c:361:28: error: variable 'dev' set but not used [-Werror=unused-but-set-variable]
361 | struct drm_device *dev;
| ^~~
cc1: all warnings being treated as errors

vim +/dev +361 drivers/gpu/drm/msm/dp/dp_debug.c

354
355 static ssize_t dp_hdcp_key_write(struct file *file, const char __user *ubuf,
356 size_t len, loff_t *offp)
357 {
358 char *input_buffer;
359 int ret = 0;
360 struct dp_debug_private *debug = file->private_data;
> 361 struct drm_device *dev;
362
363 dev = debug->drm_dev;
364
365 if (len != (DRM_HDCP_KSV_LEN + DP_HDCP_NUM_KEYS * DP_HDCP_KEY_LEN))
366 return -EINVAL;
367
368 if (!debug->hdcp)
369 return -ENOENT;
370
371 input_buffer = memdup_user_nul(ubuf, len);
372 if (IS_ERR(input_buffer))
373 return PTR_ERR(input_buffer);
374
375 ret = dp_hdcp_ingest_key(debug->hdcp, input_buffer, len);
376
377 kfree(input_buffer);
378 if (ret < 0) {
379 DRM_ERROR("Could not ingest HDCP key, ret=%d\n", ret);
380 return ret;
381 }
382
383 *offp += len;
384 return len;
385 }
386

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 79210 bytes --]