From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 141CCC433F5 for ; Tue, 28 Sep 2021 18:06:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D700E61352 for ; Tue, 28 Sep 2021 18:06:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D700E61352 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=poorly.run Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 244DE6E91D; Tue, 28 Sep 2021 18:06:23 +0000 (UTC) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by gabe.freedesktop.org (Postfix) with ESMTPS id 112816E91C for ; Tue, 28 Sep 2021 18:06:22 +0000 (UTC) Received: by mail-qk1-x732.google.com with SMTP id 73so41628039qki.4 for ; Tue, 28 Sep 2021 11:06:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poorly.run; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=jbQFOGMuTOKZGwegVTpIlO1GcuK+9dCOI/aFvlff79w=; b=E7z3kTRQP6BYuSBPNKJREQrSt7Uq0DBXGYkqoBpcNwGrRa1dkf7qKbhfqAC3SH6Mik vwKpsRXq9rrjonbiSNCGLwOLyWW63mOKe92QdcUoxpKzRh3bl18ThjaPvsx99nc8ZjXl e0dhedx1wbEqjv0NW96gcrCY9WxFLMc1hwB9UHbnVbV+8JAgJiq+V0+T4MqiWgkwkPtO 2FP2s4nfWLLWaTvFZH6Xerj4MwIdXxTgythjcuw4svDSqKvcFCDeYDkl8Foc2LDUFMVM 7BlzRIsqS8BgjYjTRc7zkuhC7KILFQs7ZIP9tmNIyP1GLbQyOkXWu1i9cufwFEdcaG4z +E2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=jbQFOGMuTOKZGwegVTpIlO1GcuK+9dCOI/aFvlff79w=; b=1K/xfoU380uvioAhxszG/fK04hEP2g/Lsqt5Ht40KPLAw+QOeMfGQ1+JimK2tfEvHy QeH+f+xtbQ//VRLmVpzN6rv7V4wHn6xmqdUWhXchMTrrH5or4smsJyd/ySLWAREmi3AA fUl1VL3fDiI9kv5ceniu4sVpwbV/uGZH8S/9r+Mki4bJAwN1XmGK7vqmghmaQGXovwBG PUYo6cn3SUjJNLZWjYVHR2OC2ZeohWy7bMrtuYj/WP/OehX61IArDcZSYOeturid+ZpC CbJRltUBl1FmMCzPRX5B9wFBnddHjIS5KQY1413qKG4BHkWfFCVfpWx21ZXseUGIfwzz K6Vg== X-Gm-Message-State: AOAM530izOuoA7OQBA44bEvR8lgCM4nwvysoP33pxmx7mim48B+9rjHd M2F7KRJCZNm53XqjG6VUlBvNVQ== X-Google-Smtp-Source: ABdhPJyqCvsm3f0vv6z72yNtFONjy2gE9DjHUmi4zAIY0uIK0nTiyRTb/KdfUqpiQvOsRnsjZO+u6Q== X-Received: by 2002:a37:2e03:: with SMTP id u3mr1320123qkh.313.1632852381004; Tue, 28 Sep 2021 11:06:21 -0700 (PDT) Received: from localhost ([167.100.64.199]) by smtp.gmail.com with ESMTPSA id y22sm14993445qkp.9.2021.09.28.11.06.20 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 28 Sep 2021 11:06:20 -0700 (PDT) Date: Tue, 28 Sep 2021 14:06:19 -0400 From: Sean Paul To: abhinavk@codeaurora.org Cc: Sean Paul , dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, freedreno@lists.freedesktop.org, swboyd@chromium.org, Sean Paul Message-ID: <20210928180619.GU2515@art_vandelay> References: <20210915203834.1439-1-sean@poorly.run> <6ccc0ce547ccb015a114a9a1292d59f6@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ccc0ce547ccb015a114a9a1292d59f6@codeaurora.org> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [Freedreno] [PATCH v2 00/13] drm/hdcp: Pull HDCP auth/exchange/check into helpers X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Sep 21, 2021 at 07:30:29PM -0700, abhinavk@codeaurora.org wrote: > Hi Sean > > On 2021-09-15 13:38, Sean Paul wrote: > > From: Sean Paul > > > > Hello again, > > This is the second version of the HDCP helper patchset. See version 1 > > here: https://patchwork.freedesktop.org/series/94623/ > > > > In this second version, I've fixed up the oopsies exposed by 0-day and > > yamllint and incorporated early review feedback from the dt/dts reviews. > > > > Please take a look, > > > > Sean > > One question overall on the series: > > 1) Regarding validation, did you run any secure video to check the > transitions? Yep, the transitions look good, no visual artifacts. Unplug/replug/suspend/resume all seem to be behaving as expected. > 2) Is running HDCP 1x compliance also part of the validation efforts? If Qualcomm has the ability to run validation, I'd be very keen to get some help in that regard. Sean > > Thanks > > Abhinav > > > > > Sean Paul (13): > > drm/hdcp: Add drm_hdcp_atomic_check() > > drm/hdcp: Avoid changing crtc state in hdcp atomic check > > drm/hdcp: Update property value on content type and user changes > > drm/hdcp: Expand HDCP helper library for enable/disable/check > > drm/i915/hdcp: Consolidate HDCP setup/state cache > > drm/i915/hdcp: Retain hdcp_capable return codes > > drm/i915/hdcp: Use HDCP helpers for i915 > > drm/msm/dpu_kms: Re-order dpu includes > > drm/msm/dpu: Remove useless checks in dpu_encoder > > drm/msm/dpu: Remove encoder->enable() hack > > drm/msm/dp: Re-order dp_audio_put in deinit_sub_modules > > dt-bindings: msm/dp: Add bindings for HDCP registers > > drm/msm: Implement HDCP 1.x using the new drm HDCP helpers > > > > .../bindings/display/msm/dp-controller.yaml | 7 +- > > arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 +- > > drivers/gpu/drm/drm_hdcp.c | 1197 ++++++++++++++++- > > drivers/gpu/drm/i915/display/intel_atomic.c | 7 +- > > drivers/gpu/drm/i915/display/intel_ddi.c | 29 +- > > .../drm/i915/display/intel_display_debugfs.c | 11 +- > > .../drm/i915/display/intel_display_types.h | 58 +- > > drivers/gpu/drm/i915/display/intel_dp_hdcp.c | 345 ++--- > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 17 +- > > drivers/gpu/drm/i915/display/intel_hdcp.c | 1011 +++----------- > > drivers/gpu/drm/i915/display/intel_hdcp.h | 35 +- > > drivers/gpu/drm/i915/display/intel_hdmi.c | 256 ++-- > > drivers/gpu/drm/msm/Makefile | 1 + > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 17 +- > > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 30 +- > > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 2 - > > drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 4 - > > drivers/gpu/drm/msm/dp/dp_debug.c | 49 +- > > drivers/gpu/drm/msm/dp/dp_debug.h | 6 +- > > drivers/gpu/drm/msm/dp/dp_display.c | 47 +- > > drivers/gpu/drm/msm/dp/dp_display.h | 5 + > > drivers/gpu/drm/msm/dp/dp_drm.c | 68 +- > > drivers/gpu/drm/msm/dp/dp_drm.h | 5 + > > drivers/gpu/drm/msm/dp/dp_hdcp.c | 433 ++++++ > > drivers/gpu/drm/msm/dp/dp_hdcp.h | 27 + > > drivers/gpu/drm/msm/dp/dp_parser.c | 22 +- > > drivers/gpu/drm/msm/dp/dp_parser.h | 4 + > > drivers/gpu/drm/msm/dp/dp_reg.h | 44 +- > > drivers/gpu/drm/msm/msm_atomic.c | 15 + > > include/drm/drm_hdcp.h | 194 +++ > > 30 files changed, 2561 insertions(+), 1389 deletions(-) > > create mode 100644 drivers/gpu/drm/msm/dp/dp_hdcp.c > > create mode 100644 drivers/gpu/drm/msm/dp/dp_hdcp.h -- Sean Paul, Software Engineer, Google / Chromium OS