From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D660AC433EF for ; Wed, 24 Nov 2021 09:44:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 245476E222; Wed, 24 Nov 2021 09:44:13 +0000 (UTC) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by gabe.freedesktop.org (Postfix) with ESMTPS id 262AB6E222; Wed, 24 Nov 2021 09:44:12 +0000 (UTC) Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id 57BF02193C; Wed, 24 Nov 2021 09:44:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1637747050; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xjctS9e3aLk//fWwNzII/UY4G5OnovggWZdyEKD1t34=; b=Fa3DfqPoxkPRyFtLFipUAPsRoQ7583RIvIkjGcirn+ZDIVuZJxTkgHZCWQWJkaYcgx/XTF 6Tg+qvMREmzgGwP+y0PqF0I8yljZj0emBD/1N75E2fyVfhSwuHdlW27Cq87y3T4+dKDpTg m3CDIAdfVxCay7j/D++92R/TIMACYbw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1637747050; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xjctS9e3aLk//fWwNzII/UY4G5OnovggWZdyEKD1t34=; b=jBk0LyCfiE1g4jR+z/f8PsVbXLRirmoGyBWY3eutEhQ8eC54ZtfGnQdZjQkRNSqRSaajn0 YL6WjUHTxaO0ZHAA== Received: from quack2.suse.cz (unknown [10.100.200.198]) by relay2.suse.de (Postfix) with ESMTP id A4AA0A3B8E; Wed, 24 Nov 2021 09:44:09 +0000 (UTC) Received: by quack2.suse.cz (Postfix, from userid 1000) id 844E41E14AC; Wed, 24 Nov 2021 10:44:09 +0100 (CET) Date: Wed, 24 Nov 2021 10:44:09 +0100 From: Jan Kara To: Luis Chamberlain Message-ID: <20211124094409.GF8583@quack2.suse.cz> References: <20211123202422.819032-1-mcgrof@kernel.org> <20211123202422.819032-7-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211123202422.819032-7-mcgrof@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH v2 6/8] inotify: simplify subdirectory registration with register_sysctl() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jack@suse.cz, airlied@linux.ie, benh@kernel.crashing.org, amir73il@gmail.com, clemens@ladisch.de, dri-devel@lists.freedesktop.org, phil@philpotter.co.uk, joseph.qi@linux.alibaba.com, mark@fasheh.com, yzaikin@google.com, keescook@chromium.org, arnd@arndb.de, intel-gfx@lists.freedesktop.org, viro@zeniv.linux.org.uk, nixiaoming@huawei.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, julia.lawall@inria.fr, ebiederm@xmission.com, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, linuxppc-dev@lists.ozlabs.org, ocfs2-devel@oss.oracle.com, jlbec@evilplan.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue 23-11-21 12:24:20, Luis Chamberlain wrote: > From: Xiaoming Ni > > There is no need to user boiler plate code to specify a set of base > directories we're going to stuff sysctls under. Simplify this by using > register_sysctl() and specifying the directory path directly. > > Move inotify_user sysctl to inotify_user.c while at it to remove clutter > from kernel/sysctl.c. > > Signed-off-by: Xiaoming Ni > [mcgrof: update commit log to reflect new path we decided to take] > Signed-off-by: Luis Chamberlain This looks fishy. You register inotify_table but not fanotify_table and remove both... Honza > --- > fs/notify/inotify/inotify_user.c | 11 ++++++++++- > include/linux/inotify.h | 3 --- > kernel/sysctl.c | 21 --------------------- > 3 files changed, 10 insertions(+), 25 deletions(-) > > diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c > index 29fca3284bb5..54583f62dc44 100644 > --- a/fs/notify/inotify/inotify_user.c > +++ b/fs/notify/inotify/inotify_user.c > @@ -58,7 +58,7 @@ struct kmem_cache *inotify_inode_mark_cachep __read_mostly; > static long it_zero = 0; > static long it_int_max = INT_MAX; > > -struct ctl_table inotify_table[] = { > +static struct ctl_table inotify_table[] = { > { > .procname = "max_user_instances", > .data = &init_user_ns.ucount_max[UCOUNT_INOTIFY_INSTANCES], > @@ -87,6 +87,14 @@ struct ctl_table inotify_table[] = { > }, > { } > }; > + > +static void __init inotify_sysctls_init(void) > +{ > + register_sysctl("fs/inotify", inotify_table); > +} > + > +#else > +#define inotify_sysctls_init() do { } while (0) > #endif /* CONFIG_SYSCTL */ > > static inline __u32 inotify_arg_to_mask(struct inode *inode, u32 arg) > @@ -849,6 +857,7 @@ static int __init inotify_user_setup(void) > inotify_max_queued_events = 16384; > init_user_ns.ucount_max[UCOUNT_INOTIFY_INSTANCES] = 128; > init_user_ns.ucount_max[UCOUNT_INOTIFY_WATCHES] = watches_max; > + inotify_sysctls_init(); > > return 0; > } > diff --git a/include/linux/inotify.h b/include/linux/inotify.h > index 6a24905f6e1e..8d20caa1b268 100644 > --- a/include/linux/inotify.h > +++ b/include/linux/inotify.h > @@ -7,11 +7,8 @@ > #ifndef _LINUX_INOTIFY_H > #define _LINUX_INOTIFY_H > > -#include > #include > > -extern struct ctl_table inotify_table[]; /* for sysctl */ > - > #define ALL_INOTIFY_BITS (IN_ACCESS | IN_MODIFY | IN_ATTRIB | IN_CLOSE_WRITE | \ > IN_CLOSE_NOWRITE | IN_OPEN | IN_MOVED_FROM | \ > IN_MOVED_TO | IN_CREATE | IN_DELETE | \ > diff --git a/kernel/sysctl.c b/kernel/sysctl.c > index 7a90a12b9ea4..6aa67c737e4e 100644 > --- a/kernel/sysctl.c > +++ b/kernel/sysctl.c > @@ -125,13 +125,6 @@ static const int maxolduid = 65535; > static const int ngroups_max = NGROUPS_MAX; > static const int cap_last_cap = CAP_LAST_CAP; > > -#ifdef CONFIG_INOTIFY_USER > -#include > -#endif > -#ifdef CONFIG_FANOTIFY > -#include > -#endif > - > #ifdef CONFIG_PROC_SYSCTL > > /** > @@ -3099,20 +3092,6 @@ static struct ctl_table fs_table[] = { > .proc_handler = proc_dointvec, > }, > #endif > -#ifdef CONFIG_INOTIFY_USER > - { > - .procname = "inotify", > - .mode = 0555, > - .child = inotify_table, > - }, > -#endif > -#ifdef CONFIG_FANOTIFY > - { > - .procname = "fanotify", > - .mode = 0555, > - .child = fanotify_table, > - }, > -#endif > #ifdef CONFIG_EPOLL > { > .procname = "epoll", > -- > 2.33.0 > -- Jan Kara SUSE Labs, CR