From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D1EAC433F5 for ; Wed, 8 Dec 2021 15:39:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CEFC0739D3; Wed, 8 Dec 2021 15:39:44 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1921D7339D; Wed, 8 Dec 2021 15:39:43 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10192"; a="224721263" X-IronPort-AV: E=Sophos;i="5.88,189,1635231600"; d="scan'208";a="224721263" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2021 07:39:42 -0800 X-IronPort-AV: E=Sophos;i="5.88,189,1635231600"; d="scan'208";a="462803287" Received: from ramaling-i9x.iind.intel.com (HELO intel.com) ([10.99.66.205]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Dec 2021 07:39:40 -0800 Date: Wed, 8 Dec 2021 21:09:22 +0530 From: Ramalingam C To: Andi Shyti Message-ID: <20211208153922.GC5006@intel.com> References: <20211208145800.27246-1-ramalingam.c@intel.com> <20211208145800.27246-3-ramalingam.c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH 2/3] drm/i915: Sanitycheck device iomem on probe X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx , Matthew Auld , dri-devel , Chris Wilson Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 2021-12-08 at 17:23:26 +0200, Andi Shyti wrote: > Hi Ram, > > > +static int intel_memory_region_memtest(struct intel_memory_region *mem, > > + void *caller) > > +{ > > + struct drm_i915_private *i915 = mem->i915; > > + int err = 0; > > + > > + if (!mem->io_start) > > + return 0; > > + > > + if (IS_ENABLED(CONFIG_DRM_I915_DEBUG_GEM)) > > + err = iomemtest(mem, caller); > > I don't understand the debugging part of the iomemtest, if memory > is failing we wouldn't relise if DEBUG_GEM is not enabled. Thanks for the review Andi! Since this is in the system init path, running the time taking mem test only (on demand basis) when the DEBUG_GEM is set or mod_param is set as per the next patch. Ram > > In any case, > > Reviewed-by: Andi Shyti > > Andi