Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: make a gt sysfs group and move power management files

Andi Shyti
2022-01-12T18:52:07Z

Hi Sujaritha,

[...]

> > +static ssize_t act_freq_mhz_show(struct device *dev,
> > + struct device_attribute *attr, char *buff)
> Alignment with the initial (

OK

[...]

> > +static INTEL_GT_RPS_SYSFS_ATTR(RP1_freq_mhz, 0444, rps_rp_mhz_show, NULL);
> > +static INTEL_GT_RPS_SYSFS_ATTR(RPn_freq_mhz, 0444, rps_rp_mhz_show, NULL);
> > +
> Multiple blank lines

OK

[...]

> I think the patch should be good to go barring the whitespace/alignment
> checks.

Thank you, will fix those and resend it,
Andi