* [Intel-gfx] [PATCH][next] drm/i915/guc: Use struct_size() helper in kmalloc()
@ 2022-01-25 18:07 Gustavo A. R. Silva
2022-01-25 21:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2022-01-25 18:07 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
David Airlie, Daniel Vetter
Cc: intel-gfx, linux-hardening, linux-kernel, dri-devel,
Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worst scenario, could lead to heap overflows.
Also, address the following sparse warnings:
drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:792:23: warning: using sizeof on a flexible structure
Link: https://github.com/KSPP/linux/issues/174
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
index aa6dd6415202..e352a1aad228 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
@@ -789,7 +789,7 @@ static struct ct_incoming_msg *ct_alloc_msg(u32 num_dwords)
{
struct ct_incoming_msg *msg;
- msg = kmalloc(sizeof(*msg) + sizeof(u32) * num_dwords, GFP_ATOMIC);
+ msg = kmalloc(struct_size(msg, msg, num_dwords), GFP_ATOMIC);
if (msg)
msg->size = num_dwords;
return msg;
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Use struct_size() helper in kmalloc() 2022-01-25 18:07 [Intel-gfx] [PATCH][next] drm/i915/guc: Use struct_size() helper in kmalloc() Gustavo A. R. Silva @ 2022-01-25 21:38 ` Patchwork 2022-01-26 0:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2022-01-26 10:08 ` [Intel-gfx] [PATCH][next] " Tvrtko Ursulin 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2022-01-25 21:38 UTC (permalink / raw) To: Gustavo A. R. Silva; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 6814 bytes --] == Series Details == Series: drm/i915/guc: Use struct_size() helper in kmalloc() URL : https://patchwork.freedesktop.org/series/99332/ State : success == Summary == CI Bug Log - changes from CI_DRM_11134 -> Patchwork_22103 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/index.html Participating hosts (47 -> 42) ------------------------------ Missing (5): fi-kbl-soraka fi-hsw-4200u fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus Known issues ------------ Here are the changes found in Patchwork_22103 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@amdgpu/amd_basic@semaphore: - fi-bsw-nick: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/fi-bsw-nick/igt@amdgpu/amd_basic@semaphore.html - fi-bdw-5557u: NOTRUN -> [SKIP][2] ([fdo#109271]) +31 similar issues [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/fi-bdw-5557u/igt@amdgpu/amd_basic@semaphore.html * igt@amdgpu/amd_cs_nop@sync-gfx0: - fi-bsw-n3050: NOTRUN -> [SKIP][3] ([fdo#109271]) +17 similar issues [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/fi-bsw-n3050/igt@amdgpu/amd_cs_nop@sync-gfx0.html * igt@i915_selftest@live@hangcheck: - bat-dg1-6: [PASS][4] -> [DMESG-FAIL][5] ([i915#4494]) [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/bat-dg1-6/igt@i915_selftest@live@hangcheck.html [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/bat-dg1-6/igt@i915_selftest@live@hangcheck.html - fi-snb-2600: [PASS][6] -> [INCOMPLETE][7] ([i915#3921]) [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/fi-snb-2600/igt@i915_selftest@live@hangcheck.html [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/fi-snb-2600/igt@i915_selftest@live@hangcheck.html * igt@kms_chamelium@dp-crc-fast: - fi-bdw-5557u: NOTRUN -> [SKIP][8] ([fdo#109271] / [fdo#111827]) +8 similar issues [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html * igt@kms_chamelium@vga-edid-read: - fi-skl-6600u: NOTRUN -> [SKIP][9] ([fdo#109271] / [fdo#111827]) +8 similar issues [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/fi-skl-6600u/igt@kms_chamelium@vga-edid-read.html * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy: - fi-skl-6600u: NOTRUN -> [SKIP][10] ([fdo#109271]) +2 similar issues [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/fi-skl-6600u/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d: - fi-skl-6600u: NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#533]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/fi-skl-6600u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html * igt@kms_psr@primary_page_flip: - fi-skl-6600u: NOTRUN -> [FAIL][12] ([i915#4547]) [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/fi-skl-6600u/igt@kms_psr@primary_page_flip.html #### Possible fixes #### * igt@gem_sync@basic-each: - fi-skl-6600u: [INCOMPLETE][13] -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/fi-skl-6600u/igt@gem_sync@basic-each.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/fi-skl-6600u/igt@gem_sync@basic-each.html * igt@i915_selftest@live@execlists: - fi-bsw-n3050: [INCOMPLETE][15] ([i915#2940]) -> [PASS][16] [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/fi-bsw-n3050/igt@i915_selftest@live@execlists.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/fi-bsw-n3050/igt@i915_selftest@live@execlists.html * igt@i915_selftest@live@late_gt_pm: - fi-bsw-nick: [DMESG-FAIL][17] ([i915#2927] / [i915#3428]) -> [PASS][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/fi-bsw-nick/igt@i915_selftest@live@late_gt_pm.html * igt@i915_selftest@live@objects: - fi-icl-u2: [DMESG-WARN][19] ([i915#2867]) -> [PASS][20] +3 similar issues [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/fi-icl-u2/igt@i915_selftest@live@objects.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/fi-icl-u2/igt@i915_selftest@live@objects.html * igt@kms_frontbuffer_tracking@basic: - fi-cml-u2: [DMESG-WARN][21] ([i915#4269]) -> [PASS][22] [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/fi-cml-u2/igt@kms_frontbuffer_tracking@basic.html #### Warnings #### * igt@runner@aborted: - fi-skl-6600u: [FAIL][23] ([i915#2722] / [i915#4312]) -> [FAIL][24] ([i915#4312]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/fi-skl-6600u/igt@runner@aborted.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/fi-skl-6600u/igt@runner@aborted.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722 [i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867 [i915#2927]: https://gitlab.freedesktop.org/drm/intel/issues/2927 [i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940 [i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428 [i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921 [i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269 [i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312 [i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494 [i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547 [i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533 Build changes ------------- * Linux: CI_DRM_11134 -> Patchwork_22103 CI-20190529: 20190529 CI_DRM_11134: 9a17b3d929e29406336a90f557b0d353bff07c76 @ git://anongit.freedesktop.org/gfx-ci/linux IGT_6332: 27c9c3f5181a840c777399be7681d2cadd7940cd @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git Patchwork_22103: 3e131eb7bac1fa31b6e313f6d0790132a3a5d221 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 3e131eb7bac1 drm/i915/guc: Use struct_size() helper in kmalloc() == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/index.html [-- Attachment #2: Type: text/html, Size: 8325 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Use struct_size() helper in kmalloc() 2022-01-25 18:07 [Intel-gfx] [PATCH][next] drm/i915/guc: Use struct_size() helper in kmalloc() Gustavo A. R. Silva 2022-01-25 21:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork @ 2022-01-26 0:25 ` Patchwork 2022-01-26 10:08 ` [Intel-gfx] [PATCH][next] " Tvrtko Ursulin 2 siblings, 0 replies; 4+ messages in thread From: Patchwork @ 2022-01-26 0:25 UTC (permalink / raw) To: Gustavo A. R. Silva; +Cc: intel-gfx [-- Attachment #1: Type: text/plain, Size: 30274 bytes --] == Series Details == Series: drm/i915/guc: Use struct_size() helper in kmalloc() URL : https://patchwork.freedesktop.org/series/99332/ State : failure == Summary == CI Bug Log - changes from CI_DRM_11134_full -> Patchwork_22103_full ==================================================== Summary ------- **FAILURE** Serious unknown changes coming with Patchwork_22103_full absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_22103_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. Participating hosts (10 -> 10) ------------------------------ No changes in participating hosts Possible new issues ------------------- Here are the unknown changes that may have been introduced in Patchwork_22103_full: ### IGT changes ### #### Possible regressions #### * igt@i915_pm_sseu@full-enable: - shard-skl: [PASS][1] -> [FAIL][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-skl10/igt@i915_pm_sseu@full-enable.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-skl6/igt@i915_pm_sseu@full-enable.html Known issues ------------ Here are the changes found in Patchwork_22103_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_eio@in-flight-contexts-immediate: - shard-skl: [PASS][3] -> [TIMEOUT][4] ([i915#3063]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-skl9/igt@gem_eio@in-flight-contexts-immediate.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-skl6/igt@gem_eio@in-flight-contexts-immediate.html * igt@gem_exec_balancer@parallel-balancer: - shard-iclb: [PASS][5] -> [SKIP][6] ([i915#4525]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-iclb1/igt@gem_exec_balancer@parallel-balancer.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-iclb5/igt@gem_exec_balancer@parallel-balancer.html * igt@gem_exec_capture@pi@bcs0: - shard-skl: [PASS][7] -> [INCOMPLETE][8] ([i915#4547]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-skl10/igt@gem_exec_capture@pi@bcs0.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-skl1/igt@gem_exec_capture@pi@bcs0.html * igt@gem_exec_fair@basic-none-vip@rcs0: - shard-kbl: [PASS][9] -> [FAIL][10] ([i915#2842]) +1 similar issue [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-kbl1/igt@gem_exec_fair@basic-none-vip@rcs0.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-kbl1/igt@gem_exec_fair@basic-none-vip@rcs0.html - shard-glk: [PASS][11] -> [FAIL][12] ([i915#2842]) [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-glk5/igt@gem_exec_fair@basic-none-vip@rcs0.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-glk3/igt@gem_exec_fair@basic-none-vip@rcs0.html * igt@gem_exec_fair@basic-none@vcs0: - shard-apl: [PASS][13] -> [FAIL][14] ([i915#2842]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-apl1/igt@gem_exec_fair@basic-none@vcs0.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl8/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fair@basic-pace@vcs1: - shard-iclb: NOTRUN -> [FAIL][15] ([i915#2842]) [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-iclb2/igt@gem_exec_fair@basic-pace@vcs1.html * igt@gem_exec_whisper@basic-contexts: - shard-glk: [PASS][16] -> [DMESG-WARN][17] ([i915#118]) [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-glk7/igt@gem_exec_whisper@basic-contexts.html [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-glk8/igt@gem_exec_whisper@basic-contexts.html * igt@gem_huc_copy@huc-copy: - shard-tglb: [PASS][18] -> [SKIP][19] ([i915#2190]) [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-tglb2/igt@gem_huc_copy@huc-copy.html [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-tglb7/igt@gem_huc_copy@huc-copy.html * igt@gem_lmem_swapping@verify-random: - shard-skl: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#4613]) +1 similar issue [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-skl9/igt@gem_lmem_swapping@verify-random.html - shard-apl: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#4613]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl1/igt@gem_lmem_swapping@verify-random.html - shard-kbl: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#4613]) [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-kbl4/igt@gem_lmem_swapping@verify-random.html * igt@gem_userptr_blits@coherency-sync: - shard-tglb: NOTRUN -> [SKIP][23] ([fdo#110542]) [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-tglb5/igt@gem_userptr_blits@coherency-sync.html * igt@gem_userptr_blits@readonly-unsync: - shard-tglb: NOTRUN -> [SKIP][24] ([i915#3297]) [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-tglb5/igt@gem_userptr_blits@readonly-unsync.html * igt@i915_pm_dc@dc6-dpms: - shard-iclb: [PASS][25] -> [FAIL][26] ([i915#454]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-iclb6/igt@i915_pm_dc@dc6-dpms.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html * igt@i915_pm_rpm@modeset-lpsp-stress-no-wait: - shard-kbl: NOTRUN -> [SKIP][27] ([fdo#109271]) +12 similar issues [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-kbl4/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html * igt@kms_async_flips@crc: - shard-skl: NOTRUN -> [FAIL][28] ([i915#4272]) [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-skl6/igt@kms_async_flips@crc.html * igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip: - shard-tglb: [PASS][29] -> [FAIL][30] ([i915#3743]) [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-tglb6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-tglb1/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0-async-flip.html * igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip: - shard-skl: NOTRUN -> [SKIP][31] ([fdo#109271] / [i915#3777]) +2 similar issues [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-skl1/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip.html * igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs: - shard-tglb: NOTRUN -> [SKIP][32] ([i915#3689] / [i915#3886]) [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-tglb6/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_mc_ccs.html * igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs_cc: - shard-kbl: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#3886]) +1 similar issue [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-kbl4/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc: - shard-skl: NOTRUN -> [SKIP][34] ([fdo#109271] / [i915#3886]) +5 similar issues [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-skl9/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc: - shard-apl: NOTRUN -> [SKIP][35] ([fdo#109271] / [i915#3886]) +3 similar issues [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl8/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html * igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_ccs: - shard-tglb: NOTRUN -> [SKIP][36] ([i915#3689]) [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-tglb6/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_ccs.html * igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_rc_ccs: - shard-apl: NOTRUN -> [SKIP][37] ([fdo#109271]) +49 similar issues [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl1/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_gen12_rc_ccs.html * igt@kms_chamelium@dp-hpd-fast: - shard-kbl: NOTRUN -> [SKIP][38] ([fdo#109271] / [fdo#111827]) +1 similar issue [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-kbl4/igt@kms_chamelium@dp-hpd-fast.html * igt@kms_color_chamelium@pipe-b-ctm-0-5: - shard-tglb: NOTRUN -> [SKIP][39] ([fdo#109284] / [fdo#111827]) +2 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-tglb6/igt@kms_color_chamelium@pipe-b-ctm-0-5.html * igt@kms_color_chamelium@pipe-c-ctm-0-5: - shard-apl: NOTRUN -> [SKIP][40] ([fdo#109271] / [fdo#111827]) +4 similar issues [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl1/igt@kms_color_chamelium@pipe-c-ctm-0-5.html * igt@kms_color_chamelium@pipe-d-degamma: - shard-skl: NOTRUN -> [SKIP][41] ([fdo#109271] / [fdo#111827]) +9 similar issues [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-skl4/igt@kms_color_chamelium@pipe-d-degamma.html * igt@kms_content_protection@lic: - shard-apl: NOTRUN -> [TIMEOUT][42] ([i915#1319]) [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl1/igt@kms_content_protection@lic.html * igt@kms_cursor_crc@pipe-a-cursor-32x32-onscreen: - shard-tglb: NOTRUN -> [SKIP][43] ([i915#3319]) [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-tglb5/igt@kms_cursor_crc@pipe-a-cursor-32x32-onscreen.html * igt@kms_cursor_crc@pipe-d-cursor-512x512-offscreen: - shard-tglb: NOTRUN -> [SKIP][44] ([fdo#109279] / [i915#3359]) [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-tglb5/igt@kms_cursor_crc@pipe-d-cursor-512x512-offscreen.html * igt@kms_cursor_legacy@pipe-d-torture-move: - shard-skl: NOTRUN -> [SKIP][45] ([fdo#109271]) +98 similar issues [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-skl4/igt@kms_cursor_legacy@pipe-d-torture-move.html * igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1: - shard-skl: [PASS][46] -> [FAIL][47] ([i915#79]) [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-skl1/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html * igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling: - shard-iclb: [PASS][48] -> [SKIP][49] ([i915#3701]) [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-iclb6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-downscaling.html * igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render: - shard-tglb: NOTRUN -> [SKIP][50] ([fdo#109280] / [fdo#111825]) +2 similar issues [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-tglb6/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-cur-indfb-draw-render.html * igt@kms_frontbuffer_tracking@fbc-suspend: - shard-kbl: [PASS][51] -> [DMESG-WARN][52] ([i915#180]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-kbl7/igt@kms_frontbuffer_tracking@fbc-suspend.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-suspend.html * igt@kms_hdr@bpc-switch: - shard-skl: [PASS][53] -> [FAIL][54] ([i915#1188]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-skl8/igt@kms_hdr@bpc-switch.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-skl10/igt@kms_hdr@bpc-switch.html * igt@kms_hdr@bpc-switch-dpms: - shard-skl: NOTRUN -> [FAIL][55] ([i915#1188]) [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-skl6/igt@kms_hdr@bpc-switch-dpms.html * igt@kms_pipe_crc_basic@read-crc-pipe-d: - shard-apl: NOTRUN -> [SKIP][56] ([fdo#109271] / [i915#533]) [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl1/igt@kms_pipe_crc_basic@read-crc-pipe-d.html * igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes: - shard-apl: [PASS][57] -> [DMESG-WARN][58] ([i915#180]) +3 similar issues [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend@pipe-a-planes.html * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min: - shard-skl: [PASS][59] -> [FAIL][60] ([fdo#108145] / [i915#265]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html * igt@kms_plane_alpha_blend@pipe-c-alpha-basic: - shard-kbl: NOTRUN -> [FAIL][61] ([fdo#108145] / [i915#265]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-kbl4/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html - shard-apl: NOTRUN -> [FAIL][62] ([fdo#108145] / [i915#265]) +1 similar issue [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl1/igt@kms_plane_alpha_blend@pipe-c-alpha-basic.html * igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max: - shard-skl: NOTRUN -> [FAIL][63] ([fdo#108145] / [i915#265]) +1 similar issue [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max.html * igt@kms_psr2_su@frontbuffer-xrgb8888: - shard-skl: NOTRUN -> [SKIP][64] ([fdo#109271] / [i915#658]) [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-skl4/igt@kms_psr2_su@frontbuffer-xrgb8888.html * igt@kms_psr@psr2_cursor_mmap_cpu: - shard-iclb: [PASS][65] -> [SKIP][66] ([fdo#109441]) +1 similar issue [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-iclb7/igt@kms_psr@psr2_cursor_mmap_cpu.html * igt@kms_vblank@pipe-a-ts-continuation-suspend: - shard-apl: [PASS][67] -> [DMESG-WARN][68] ([i915#180] / [i915#295]) [67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-apl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl8/igt@kms_vblank@pipe-a-ts-continuation-suspend.html * igt@kms_vblank@pipe-b-ts-continuation-suspend: - shard-apl: NOTRUN -> [DMESG-WARN][69] ([i915#180]) [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl8/igt@kms_vblank@pipe-b-ts-continuation-suspend.html * igt@sysfs_clients@busy: - shard-apl: NOTRUN -> [SKIP][70] ([fdo#109271] / [i915#2994]) [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl8/igt@sysfs_clients@busy.html * igt@sysfs_clients@split-50: - shard-skl: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#2994]) [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-skl4/igt@sysfs_clients@split-50.html #### Possible fixes #### * igt@gem_eio@kms: - shard-tglb: [TIMEOUT][72] ([i915#3063]) -> [PASS][73] [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-tglb5/igt@gem_eio@kms.html [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-tglb7/igt@gem_eio@kms.html * igt@gem_eio@unwedge-stress: - shard-tglb: [FAIL][74] ([i915#232]) -> [PASS][75] [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-tglb2/igt@gem_eio@unwedge-stress.html [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-tglb7/igt@gem_eio@unwedge-stress.html * igt@gem_exec_balancer@parallel-keep-submit-fence: - shard-iclb: [SKIP][76] ([i915#4525]) -> [PASS][77] +1 similar issue [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-iclb5/igt@gem_exec_balancer@parallel-keep-submit-fence.html [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-iclb4/igt@gem_exec_balancer@parallel-keep-submit-fence.html * igt@gem_exec_big@single: - shard-tglb: [TIMEOUT][78] -> [PASS][79] [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-tglb1/igt@gem_exec_big@single.html [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-tglb2/igt@gem_exec_big@single.html * igt@gem_exec_fair@basic-none-rrul@rcs0: - shard-glk: [FAIL][80] ([i915#2842]) -> [PASS][81] [80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-glk4/igt@gem_exec_fair@basic-none-rrul@rcs0.html [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-glk5/igt@gem_exec_fair@basic-none-rrul@rcs0.html * igt@gem_exec_fair@basic-none@vcs0: - shard-kbl: [FAIL][82] ([i915#2842]) -> [PASS][83] +2 similar issues [82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-kbl3/igt@gem_exec_fair@basic-none@vcs0.html [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-kbl1/igt@gem_exec_fair@basic-none@vcs0.html * igt@gem_exec_fair@basic-pace-share@rcs0: - shard-tglb: [FAIL][84] ([i915#2842]) -> [PASS][85] [84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-tglb5/igt@gem_exec_fair@basic-pace-share@rcs0.html [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-tglb2/igt@gem_exec_fair@basic-pace-share@rcs0.html * igt@kms_big_fb@x-tiled-32bpp-rotate-180: - shard-glk: [DMESG-WARN][86] ([i915#118]) -> [PASS][87] [86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-glk6/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-glk3/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html * igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip: - shard-tglb: [FAIL][88] ([i915#3743]) -> [PASS][89] [88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-tglb1/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-tglb5/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html * igt@kms_color@pipe-c-ctm-negative: - shard-tglb: [DMESG-WARN][90] ([i915#1149] / [i915#1982]) -> [PASS][91] [90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-tglb1/igt@kms_color@pipe-c-ctm-negative.html [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-tglb3/igt@kms_color@pipe-c-ctm-negative.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-skl: [INCOMPLETE][92] ([i915#2828] / [i915#300]) -> [PASS][93] [92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-skl9/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-skl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size: - shard-iclb: [FAIL][94] ([i915#2346]) -> [PASS][95] [94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-iclb7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html [95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-iclb2/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1: - shard-kbl: [DMESG-WARN][96] ([i915#180]) -> [PASS][97] +1 similar issue [96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html [97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-kbl4/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html * igt@kms_flip@flip-vs-suspend-interruptible@a-edp1: - shard-skl: [INCOMPLETE][98] -> [PASS][99] [98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-skl10/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html [99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-skl9/igt@kms_flip@flip-vs-suspend-interruptible@a-edp1.html * igt@kms_flip@flip-vs-suspend-interruptible@c-dp1: - shard-apl: [DMESG-WARN][100] ([i915#180]) -> [PASS][101] +2 similar issues [100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-apl8/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html [101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible@c-dp1.html * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-render: - shard-glk: [FAIL][102] ([i915#2546]) -> [PASS][103] [102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-glk4/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-render.html [103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-glk5/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-render.html * igt@kms_hdr@bpc-switch-suspend: - shard-skl: [FAIL][104] ([i915#1188]) -> [PASS][105] [104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-skl4/igt@kms_hdr@bpc-switch-suspend.html [105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-skl9/igt@kms_hdr@bpc-switch-suspend.html * igt@kms_psr@psr2_basic: - shard-iclb: [SKIP][106] ([fdo#109441]) -> [PASS][107] +1 similar issue [106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-iclb7/igt@kms_psr@psr2_basic.html [107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-iclb2/igt@kms_psr@psr2_basic.html * igt@kms_setmode@basic: - shard-apl: [FAIL][108] ([i915#31]) -> [PASS][109] [108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-apl1/igt@kms_setmode@basic.html [109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl7/igt@kms_setmode@basic.html - shard-glk: [FAIL][110] ([i915#31]) -> [PASS][111] [110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-glk1/igt@kms_setmode@basic.html [111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-glk4/igt@kms_setmode@basic.html * igt@perf@polling: - shard-tglb: [FAIL][112] ([i915#1542]) -> [PASS][113] [112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-tglb1/igt@perf@polling.html [113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-tglb2/igt@perf@polling.html * igt@perf@polling-small-buf: - shard-tglb: [FAIL][114] ([i915#1722]) -> [PASS][115] [114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-tglb1/igt@perf@polling-small-buf.html [115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-tglb3/igt@perf@polling-small-buf.html #### Warnings #### * igt@gem_exec_fair@basic-pace@bcs0: - shard-tglb: [SKIP][116] ([i915#2848]) -> [FAIL][117] ([i915#2842]) +5 similar issues [116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-tglb1/igt@gem_exec_fair@basic-pace@bcs0.html [117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-tglb3/igt@gem_exec_fair@basic-pace@bcs0.html * igt@i915_pm_rc6_residency@rc6-idle: - shard-iclb: [WARN][118] ([i915#2684]) -> [WARN][119] ([i915#1804] / [i915#2684]) [118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html [119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-iclb6/igt@i915_pm_rc6_residency@rc6-idle.html * igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_rc_ccs_cc: - shard-glk: [SKIP][120] ([fdo#109271] / [i915#1888]) -> [SKIP][121] ([fdo#109271]) [120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-glk4/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html [121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-glk5/igt@kms_ccs@pipe-d-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html * igt@kms_psr2_sf@primary-plane-update-sf-dmg-area: - shard-iclb: [SKIP][122] ([fdo#111068] / [i915#658]) -> [SKIP][123] ([i915#2920]) [122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-iclb6/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html [123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-iclb2/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html * igt@runner@aborted: - shard-kbl: ([FAIL][124], [FAIL][125], [FAIL][126]) ([i915#180] / [i915#3002] / [i915#4312]) -> ([FAIL][127], [FAIL][128], [FAIL][129]) ([fdo#109271] / [i915#1814] / [i915#3002] / [i915#4312]) [124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-kbl4/igt@runner@aborted.html [125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-kbl6/igt@runner@aborted.html [126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-kbl4/igt@runner@aborted.html [127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-kbl6/igt@runner@aborted.html [128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-kbl3/igt@runner@aborted.html [129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-kbl6/igt@runner@aborted.html - shard-apl: ([FAIL][130], [FAIL][131], [FAIL][132], [FAIL][133], [FAIL][134], [FAIL][135], [FAIL][136]) ([i915#180] / [i915#3002] / [i915#4312]) -> ([FAIL][137], [FAIL][138], [FAIL][139], [FAIL][140], [FAIL][141], [FAIL][142], [FAIL][143], [FAIL][144], [FAIL][145]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#3002] / [i915#4312]) [130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-apl1/igt@runner@aborted.html [131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-apl2/igt@runner@aborted.html [132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-apl1/igt@runner@aborted.html [133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-apl1/igt@runner@aborted.html [134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-apl3/igt@runner@aborted.html [135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-apl7/igt@runner@aborted.html [136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11134/shard-apl8/igt@runner@aborted.html [137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl2/igt@runner@aborted.html [138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl4/igt@runner@aborted.html [139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl3/igt@runner@aborted.html [140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl8/igt@runner@aborted.html [141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl7/igt@runner@aborted.html [142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl7/igt@runner@aborted.html [143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl8/igt@runner@aborted.html [144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl6/igt@runner@aborted.html [145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/shard-apl8/igt@runner@aborted.html [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145 [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279 [fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280 [fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#1149]: https://gitlab.freedesktop.org/drm/intel/issues/1149 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188 [i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319 [i915#1542]: https://gitlab.freedesktop.org/drm/intel/issues/1542 [i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1804]: https://gitlab.freedesktop.org/drm/intel/issues/1804 [i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190 [i915#232]: https://gitlab.freedesktop.org/drm/intel/issues/232 [i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346 [i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546 [i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265 [i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684 [i915#2828]: https://gitlab.freedesktop.o == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22103/index.html [-- Attachment #2: Type: text/html, Size: 36143 bytes --] ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Intel-gfx] [PATCH][next] drm/i915/guc: Use struct_size() helper in kmalloc() 2022-01-25 18:07 [Intel-gfx] [PATCH][next] drm/i915/guc: Use struct_size() helper in kmalloc() Gustavo A. R. Silva 2022-01-25 21:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2022-01-26 0:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork @ 2022-01-26 10:08 ` Tvrtko Ursulin 2 siblings, 0 replies; 4+ messages in thread From: Tvrtko Ursulin @ 2022-01-26 10:08 UTC (permalink / raw) To: Gustavo A. R. Silva, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie, Daniel Vetter Cc: intel-gfx, linux-kernel, dri-devel, linux-hardening On 25/01/2022 18:07, Gustavo A. R. Silva wrote: > Make use of the struct_size() helper instead of an open-coded version, > in order to avoid any potential type mistakes or integer overflows that, > in the worst scenario, could lead to heap overflows. > > Also, address the following sparse warnings: > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:792:23: warning: using sizeof on a flexible structure > > Link: https://github.com/KSPP/linux/issues/174 > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c > index aa6dd6415202..e352a1aad228 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c > @@ -789,7 +789,7 @@ static struct ct_incoming_msg *ct_alloc_msg(u32 num_dwords) > { > struct ct_incoming_msg *msg; > > - msg = kmalloc(sizeof(*msg) + sizeof(u32) * num_dwords, GFP_ATOMIC); > + msg = kmalloc(struct_size(msg, msg, num_dwords), GFP_ATOMIC); > if (msg) > msg->size = num_dwords; > return msg; > Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> Thanks for the patch, will merge shortly. Regards, Tvrtko ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-01-26 10:08 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-01-25 18:07 [Intel-gfx] [PATCH][next] drm/i915/guc: Use struct_size() helper in kmalloc() Gustavo A. R. Silva 2022-01-25 21:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2022-01-26 0:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork 2022-01-26 10:08 ` [Intel-gfx] [PATCH][next] " Tvrtko Ursulin
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox