Re: [Intel-gfx] [PATCH 11/20] drm/i915/ttm: tweak priority hint selection

Thomas Hellström
2022-02-02T13:34:55Z

On 1/26/22 16:21, Matthew Auld wrote:
> For some reason we are selecting PRIO_HAS_PAGES when we don't have
> mm.pages, and vice versa. Perhaps something else is going on here.
>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>

LGTM. Should we add a Fixes: tag here?

Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>

> ---
> drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> index e60b677ecd54..e4cd6ccf5ab1 100644
> --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c
> @@ -848,11 +848,9 @@ void i915_ttm_adjust_lru(struct drm_i915_gem_object *obj)
> } else if (obj->mm.madv != I915_MADV_WILLNEED) {
> bo->priority = I915_TTM_PRIO_PURGE;
> } else if (!i915_gem_object_has_pages(obj)) {
> - if (bo->priority < I915_TTM_PRIO_HAS_PAGES)
> - bo->priority = I915_TTM_PRIO_HAS_PAGES;
> + bo->priority = I915_TTM_PRIO_NO_PAGES;
> } else {
> - if (bo->priority > I915_TTM_PRIO_NO_PAGES)
> - bo->priority = I915_TTM_PRIO_NO_PAGES;
> + bo->priority = I915_TTM_PRIO_HAS_PAGES;
> }
>
> ttm_bo_move_to_lru_tail(bo, bo->resource, NULL);