Re: [Intel-gfx] [PATCH 08/20] drm/i915/buddy: adjust res->start

Thomas Hellström
2022-02-01T10:38:15Z

On Wed, 2022-01-26 at 15:21 +0000, Matthew Auld wrote:
> Differentiate between mappable vs non-mappable resources, also if
> this
> is an actual range allocation ensure we set res->start as the
> starting
> pfn. Later when we need to do non-mappable -> mappable moves then we
> want TTM to see that the current placement is not compatible, which
> should result in an actual move, instead of being turned into a noop.
>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>

Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>

> ---
>  drivers/gpu/drm/i915/i915_ttm_buddy_manager.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_ttm_buddy_manager.c
> b/drivers/gpu/drm/i915/i915_ttm_buddy_manager.c
> index 6e5842155898..bc725a92fc5c 100644
> --- a/drivers/gpu/drm/i915/i915_ttm_buddy_manager.c
> +++ b/drivers/gpu/drm/i915/i915_ttm_buddy_manager.c
> @@ -140,6 +140,13 @@ static int i915_ttm_buddy_man_alloc(struct
> ttm_resource_manager *man,
>                 mutex_unlock(&bman->lock);
>         }
>
> +       if (place->lpfn - place->fpfn == n_pages)
> +               bman_res->base.start = place->fpfn;
> +       else if (lpfn <= bman->visible_size)
> +               bman_res->base.start = 0;
> +       else
> +               bman_res->base.start = bman->visible_size;
> +
>         *res = &bman_res->base;
>         return 0;
>