Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Re-work invalidate_csb_entries

Matthew Auld
2022-01-28T10:00:54Z

On Thu, 27 Jan 2022 at 23:41, Michael Cheng <michael.cheng@intel.com> wrote:
>
> Re-work invalidate_csb_entries to use drm_clflush_virt_range. This will
> prevent compiler errors when building for non-x86 architectures.
>
> Signed-off-by: Michael Cheng <michael.cheng@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> index 960a9aaf4f3a..90b5daf9433d 100644
> --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> @@ -1647,8 +1647,8 @@ cancel_port_requests(struct intel_engine_execlists * const execlists,
>
> static void invalidate_csb_entries(const u64 *first, const u64 *last)
> {
> - clflush((void *)first);
> - clflush((void *)last);
> + drm_clflush_virt_range((void *)first, sizeof(*first));
> + drm_clflush_virt_range((void *)last, sizeof(*last));

Could maybe drop the (void *) casting,
Reviewed-by: Matthew Auld <matthew.auld@intel.com>

> }
>
> /*
> --
> 2.25.1
>