From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77835C433F5 for ; Mon, 7 Feb 2022 08:35:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BBC9E10E28F; Mon, 7 Feb 2022 08:35:40 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by gabe.freedesktop.org (Postfix) with ESMTPS id C9F0910F50C; Mon, 7 Feb 2022 08:35:39 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 3862868AFE; Mon, 7 Feb 2022 09:35:36 +0100 (CET) Date: Mon, 7 Feb 2022 09:35:35 +0100 From: Christoph Hellwig To: "Wang, Zhi A" Message-ID: <20220207083535.GA25345@lst.de> References: <20220127120508.11330-1-zhi.a.wang@intel.com> <20220207073247.GA24327@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Subject: Re: [Intel-gfx] [PATCH 1/3] i915/gvt: Introduce the mmio_table.c to support VFIO new mdev API X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhi Wang , "intel-gfx@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , "Xu, Terrence" , "dri-devel@lists.freedesktop.org" , "jgg@nvidia.com" , "intel-gvt-dev@lists.freedesktop.org" , Christoph Hellwig Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Feb 07, 2022 at 08:28:13AM +0000, Wang, Zhi A wrote: > 1) About having the mmio_table.h, I would like to keep the stuff in a dedicated header as putting them in intel_gvt.h might needs i915 guys to maintain it. > 2) The other one is about if we should move the mmio_table.c into i915 folder. I guess we need the some comments from Jani. In the current version that I am testing, it's still in GVT folder. Guess we can submit a patch to move it to i915 folder later if Jani is ok about that. Yes, let's have Jani chime in on these. They're basically one and the same issue. This code will have to be built into into the core i915 driver even with my planned split, which is kindof the point of this exercise. I think it makes sense to use the subdirectories as boundaries for where the code ends up and not to declarare maintainership boundaries, but it will be up to the i915 and gvt maintainers to decide that.