From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E164C433F5 for ; Wed, 9 Feb 2022 09:09:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9619910E657; Wed, 9 Feb 2022 09:09:24 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id A903310E657 for ; Wed, 9 Feb 2022 09:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=kNBxEECZ8nYVRQBlRi4s4bPsYk+6wGvc+UHQLe+LfQY=; b=FuT01ILcnQE1hlwV0N6QoRzje7 8leIgTUsGHbhfy7cNPjN8ZrjHcSG0wypOKtgyb8t04GcdHB5bH2yXofjaCs8wpl1CIqqOkec3R9OV nApYAVlzrV8ZfypyHa4mIELkzUQhBcEibVe6rjqueMf/NegoUT6rvZNNsoc4Uw2YqsFP9t1UTNqIf jNC72U1XwX8JGYxfA0nQlHqSjCcVfzkGjPBeAtSDlLt6otVC5r0jjKiMiAMeC9xmjVZ1sMuKSSBys rCFVdCTkXxb8dN7UTtpmiYJWVdWQaduq6Qanmd7JpqkCzBgIpJKnbvw5fQS2u7k6VjPF4p+ScGV/Y cDMFRHqA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=worktop.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHiyL-007ELN-4I; Wed, 09 Feb 2022 09:09:09 +0000 Received: by worktop.programming.kicks-ass.net (Postfix, from userid 1000) id B7873986226; Wed, 9 Feb 2022 10:09:08 +0100 (CET) Date: Wed, 9 Feb 2022 10:09:08 +0100 From: Peter Zijlstra To: Namhyung Kim Message-ID: <20220209090908.GK23216@worktop.programming.kicks-ass.net> References: <20220208184208.79303-1-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220208184208.79303-1-namhyung@kernel.org> Subject: Re: [Intel-gfx] [RFC 00/12] locking: Separate lock tracepoints from lockdep/lock_stat (v1) X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: rcu@vger.kernel.org, intel-gfx@lists.freedesktop.org, Boqun Feng , LKML , Steven Rostedt , Radoslaw Burny , Byungchul Park , "Paul E. McKenney" , Mathieu Desnoyers , cgroups@vger.kernel.org, Tejun Heo , Waiman Long , Thomas Gleixner , Will Deacon , Ingo Molnar , linux-btrfs@vger.kernel.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Feb 08, 2022 at 10:41:56AM -0800, Namhyung Kim wrote: > Eventually I'm mostly interested in the contended locks only and I > want to reduce the overhead in the fast path. By moving that, it'd be > easy to track contended locks with timing by using two tracepoints. So why not put in two new tracepoints and call it a day? Why muck about with all that lockdep stuff just to preserve the name (and in the process continue to blow up data structures etc..). This leaves distros in a bind, will they enable this config and provide tracepoints while bloating the data structures and destroying things like lockref (which relies on sizeof(spinlock_t)), or not provide this at all. Yes, the name is convenient, but it's just not worth it IMO. It makes the whole proposition too much of a trade-off. Would it not be possible to reconstruct enough useful information from the lock callsite?