From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DC09C4332F for ; Fri, 18 Feb 2022 20:42:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 08A7410E18A; Fri, 18 Feb 2022 20:42:26 +0000 (UTC) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6846310E13E; Fri, 18 Feb 2022 20:42:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645216944; x=1676752944; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=ExycIC81nz2tFIifOp20Enbl3c3rKWHchsGM9iUoqs8=; b=izjw0bAnbzBbyn1kPZ0czfXtNak5u+goO5hyzg6ZgowofHETSkJWM8pH +o/HJNaFK0TGrndjZifRz9sHqCvzu6U2jpduDYJHY8U7qkdQaupM4MTUt aoz7XBwVXERz/54SuQ3x5PFSNWlNF10+v2DiKnW6pjq7YNHCYP2UtWYRP xoFfy05gy/o20kU5H/2ar+U+vsLS8PXmltZWmk2rs/NPtizDJNS0TOENo ZoOU2/2/ewF1blehuniKD+ZUkfFBY8trwBPxZOCCVV5uFVz+fQkGx2GJE vc63EQ3AD5tvOXeAqgvozjaaas28oI5pSvMm5y4/QDKVcZU43g0S3L4lU w==; X-IronPort-AV: E=McAfee;i="6200,9189,10262"; a="231183739" X-IronPort-AV: E=Sophos;i="5.88,379,1635231600"; d="scan'208";a="231183739" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 12:42:23 -0800 X-IronPort-AV: E=Sophos;i="5.88,379,1635231600"; d="scan'208";a="637871221" Received: from jons-linux-dev-box.fm.intel.com (HELO jons-linux-dev-box) ([10.1.27.20]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 12:42:10 -0800 Date: Fri, 18 Feb 2022 12:36:19 -0800 From: Matthew Brost To: Lucas De Marchi Message-ID: <20220218203619.GA3259@jons-linux-dev-box> References: <20220216174147.3073235-1-lucas.demarchi@intel.com> <20220216174147.3073235-10-lucas.demarchi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220216174147.3073235-10-lucas.demarchi@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [PATCH v3 09/16] drm/i915/guc: Convert guc_ads_private_data_reset to iosys_map X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas =?iso-8859-1?Q?Hellstr=F6m?= , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Sumit Semwal , Thomas Zimmermann , Christian =?iso-8859-1?Q?K=F6nig?= Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Feb 16, 2022 at 09:41:40AM -0800, Lucas De Marchi wrote: > Use iosys_map_memset() to zero the private data as ADS may be either > on system or IO memory. > > Cc: Matt Roper > Cc: Thomas Hellström > Cc: Daniel Vetter > Cc: John Harrison > Cc: Matthew Brost > Cc: Daniele Ceraolo Spurio > Signed-off-by: Lucas De Marchi Reviewed-by: Matthew Brost > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c > index c61648ef3920..d924486490c1 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c > @@ -714,8 +714,8 @@ static void guc_ads_private_data_reset(struct intel_guc *guc) > if (!size) > return; > > - memset((void *)guc->ads_blob + guc_ads_private_data_offset(guc), 0, > - size); > + iosys_map_memset(&guc->ads_map, guc_ads_private_data_offset(guc), > + 0, size); > } > > /** > -- > 2.35.1 >