From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2DC1AC433EF for ; Fri, 18 Feb 2022 20:51:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA6ED10E4B9; Fri, 18 Feb 2022 20:51:25 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2ADF810E4B9; Fri, 18 Feb 2022 20:51:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645217484; x=1676753484; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=516zcotZ4vKJxew/o+TSv3WXclgDhYK9iJrfeEkN4bs=; b=BUgmq8l0IM3gGvC9zx6Dtslq/DXcUTyLAUO2Q9whMdLl6vhgTdKpOoDr GLbK1l3QceqqFayXMTzPFTFjD6t9l7tFhcc06+NqXGNVM0To1y9r1N/Ag nmTlLvFMC66l3636H/RR2IcnNSTUGxfsZI5BMr4opaxdrctKX0JraJrZf v4J6dWAtNde9qPUt9o2YqDj1SDHMqICYxUXBpIKSC2a4LlMykQg+Q3WZ5 GWmFHBwAcF6MXDb1ZpVW5SrPEHGIbYUaufUNoBwnVMfQDdNoH0OTeItfo lq6+jntR5qGhWczXm7wEIlFTAFMyJ+b+z1lCJGMKaWe4Pv7eL/uoY+sGB Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10262"; a="275802167" X-IronPort-AV: E=Sophos;i="5.88,379,1635231600"; d="scan'208";a="275802167" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 12:51:23 -0800 X-IronPort-AV: E=Sophos;i="5.88,379,1635231600"; d="scan'208";a="705519738" Received: from jons-linux-dev-box.fm.intel.com (HELO jons-linux-dev-box) ([10.1.27.20]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 12:51:23 -0800 Date: Fri, 18 Feb 2022 12:45:32 -0800 From: Matthew Brost To: Lucas De Marchi Message-ID: <20220218204532.GA3351@jons-linux-dev-box> References: <20220216174147.3073235-1-lucas.demarchi@intel.com> <20220216174147.3073235-13-lucas.demarchi@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220216174147.3073235-13-lucas.demarchi@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [PATCH v3 12/16] drm/i915/guc: Convert mapping table to iosys_map X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas =?iso-8859-1?Q?Hellstr=F6m?= , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Sumit Semwal , Thomas Zimmermann , Christian =?iso-8859-1?Q?K=F6nig?= Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Feb 16, 2022 at 09:41:43AM -0800, Lucas De Marchi wrote: > Use iosys_map to write the fields system_info.mapping_table[][]. > Since we already have the info_map around where needed, just use it > instead of going through guc->ads_map. > > Cc: Matt Roper > Cc: Thomas Hellström > Cc: Daniel Vetter > Cc: John Harrison > Cc: Matthew Brost > Cc: Daniele Ceraolo Spurio > Signed-off-by: Lucas De Marchi Reviewed-by: Matthew Brost > --- > drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c > index b739781bd133..c3c31b679e79 100644 > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c > @@ -204,7 +204,7 @@ int intel_guc_global_policies_update(struct intel_guc *guc) > } > > static void guc_mapping_table_init(struct intel_gt *gt, > - struct guc_gt_system_info *system_info) > + struct iosys_map *info_map) > { > unsigned int i, j; > struct intel_engine_cs *engine; > @@ -213,14 +213,14 @@ static void guc_mapping_table_init(struct intel_gt *gt, > /* Table must be set to invalid values for entries not used */ > for (i = 0; i < GUC_MAX_ENGINE_CLASSES; ++i) > for (j = 0; j < GUC_MAX_INSTANCES_PER_CLASS; ++j) > - system_info->mapping_table[i][j] = > - GUC_MAX_INSTANCES_PER_CLASS; > + info_map_write(info_map, mapping_table[i][j], > + GUC_MAX_INSTANCES_PER_CLASS); > > for_each_engine(engine, gt, id) { > u8 guc_class = engine_class_to_guc_class(engine->class); > > - system_info->mapping_table[guc_class][ilog2(engine->logical_mask)] = > - engine->instance; > + info_map_write(info_map, mapping_table[guc_class][ilog2(engine->logical_mask)], > + engine->instance); > } > } > > @@ -631,7 +631,7 @@ static void __guc_ads_init(struct intel_guc *guc) > /* Golden contexts for re-initialising after a watchdog reset */ > guc_prep_golden_context(guc); > > - guc_mapping_table_init(guc_to_gt(guc), &blob->system_info); > + guc_mapping_table_init(guc_to_gt(guc), &info_map); > > base = intel_guc_ggtt_offset(guc, guc->ads_vma); > > -- > 2.35.1 >