[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Refactor ADS access to use iosys_map (rev3)

Patchwork
2022-02-17T07:24:48Z

== Series Details ==

Series: drm/i915/guc: Refactor ADS access to use iosys_map (rev3)
URL : https://patchwork.freedesktop.org/series/99711/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
3c4f364a17be iosys-map: Add offset to iosys_map_memcpy_to()
7ab81996b485 iosys-map: Add a few more helpers
-:102: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'map_' may be better as '(map_)' to avoid precedence issues
#102: FILE: include/linux/iosys-map.h:156:
+#define IOSYS_MAP_INIT_OFFSET(map_, offset_) ({ \
+ struct iosys_map copy = *map_; \
+ iosys_map_incr(&copy, offset_); \
+ copy; \
+})

-:257: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'struct_offset__' may be better as '(struct_offset__)' to avoid precedence issues
#257: FILE: include/linux/iosys-map.h:432:
+#define iosys_map_rd_field(map__, struct_offset__, struct_type__, field__) ({ \
+ struct_type__ *s; \
+ iosys_map_rd(map__, struct_offset__ + offsetof(struct_type__, field__), \
+ typeof(s->field__)); \
+})

-:257: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'struct_type__' may be better as '(struct_type__)' to avoid precedence issues
#257: FILE: include/linux/iosys-map.h:432:
+#define iosys_map_rd_field(map__, struct_offset__, struct_type__, field__) ({ \
+ struct_type__ *s; \
+ iosys_map_rd(map__, struct_offset__ + offsetof(struct_type__, field__), \
+ typeof(s->field__)); \
+})

-:257: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'field__' - possible side-effects?
#257: FILE: include/linux/iosys-map.h:432:
+#define iosys_map_rd_field(map__, struct_offset__, struct_type__, field__) ({ \
+ struct_type__ *s; \
+ iosys_map_rd(map__, struct_offset__ + offsetof(struct_type__, field__), \
+ typeof(s->field__)); \
+})

-:278: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'struct_offset__' may be better as '(struct_offset__)' to avoid precedence issues
#278: FILE: include/linux/iosys-map.h:453:
+#define iosys_map_wr_field(map__, struct_offset__, struct_type__, field__, val__) ({ \
+ struct_type__ *s; \
+ iosys_map_wr(map__, struct_offset__ + offsetof(struct_type__, field__), \
+ typeof(s->field__), val__); \
+})

-:278: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'struct_type__' may be better as '(struct_type__)' to avoid precedence issues
#278: FILE: include/linux/iosys-map.h:453:
+#define iosys_map_wr_field(map__, struct_offset__, struct_type__, field__, val__) ({ \
+ struct_type__ *s; \
+ iosys_map_wr(map__, struct_offset__ + offsetof(struct_type__, field__), \
+ typeof(s->field__), val__); \
+})

-:278: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'field__' - possible side-effects?
#278: FILE: include/linux/iosys-map.h:453:
+#define iosys_map_wr_field(map__, struct_offset__, struct_type__, field__, val__) ({ \
+ struct_type__ *s; \
+ iosys_map_wr(map__, struct_offset__ + offsetof(struct_type__, field__), \
+ typeof(s->field__), val__); \
+})

total: 0 errors, 0 warnings, 7 checks, 217 lines checked
b26af08d993c drm/i915/gt: Add helper for shmem copy to iosys_map
7a7bd9870c5e drm/i915/guc: Keep iosys_map of ads_blob around
955dd8aab6d5 drm/i915/guc: Add read/write helpers for ADS blob
d69fd819ad0b drm/i915/guc: Convert golden context init to iosys_map
23e5eaa48251 drm/i915/guc: Convert policies update to iosys_map
af050820f83c drm/i915/guc: Convert engine record to iosys_map
0481cbf77890 drm/i915/guc: Convert guc_ads_private_data_reset to iosys_map
3115fab4b911 drm/i915/guc: Convert golden context prep to iosys_map
70f013d0a2ad drm/i915/guc: Replace check for golden context size
c4b18c55e3d1 drm/i915/guc: Convert mapping table to iosys_map
f5682a7a730d drm/i915/guc: Convert capture list to iosys_map
79242ec38bba drm/i915/guc: Convert guc_mmio_reg_state_init to iosys_map
aa46f3f7041b drm/i915/guc: Convert __guc_ads_init to iosys_map
-:42: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#42: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c:623:
+ ads_blob_write(guc, system_info.generic_gt_sysinfo[GUC_GENERIC_GT_SYSINFO_VDBOX_SFC_SUPPORT_MASK],

-:52: WARNING:LONG_LINE: line length of 111 exceeds 100 columns
#52: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c:630:
+ system_info.generic_gt_sysinfo[GUC_GENERIC_GT_SYSINFO_DOORBELL_COUNT_PER_SQIDI],

total: 0 errors, 2 warnings, 0 checks, 52 lines checked
14d3c077b299 drm/i915/guc: Remove plain ads_blob pointer