[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Refactor ADS access to use iosys_map (rev4)

Patchwork
2022-02-18T19:44:26Z

== Series Details ==

Series: drm/i915/guc: Refactor ADS access to use iosys_map (rev4)
URL : https://patchwork.freedesktop.org/series/99711/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
554203971464 iosys-map: Add offset to iosys_map_memcpy_to()
5a68a5465b0a iosys-map: Add a few more helpers
-:103: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'map_' may be better as '(map_)' to avoid precedence issues
#103: FILE: include/linux/iosys-map.h:156:
+#define IOSYS_MAP_INIT_OFFSET(map_, offset_) ({ \
+ struct iosys_map copy = *map_; \
+ iosys_map_incr(&copy, offset_); \
+ copy; \
+})

-:258: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'struct_offset__' may be better as '(struct_offset__)' to avoid precedence issues
#258: FILE: include/linux/iosys-map.h:432:
+#define iosys_map_rd_field(map__, struct_offset__, struct_type__, field__) ({ \
+ struct_type__ *s; \
+ iosys_map_rd(map__, struct_offset__ + offsetof(struct_type__, field__), \
+ typeof(s->field__)); \
+})

-:258: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'struct_type__' may be better as '(struct_type__)' to avoid precedence issues
#258: FILE: include/linux/iosys-map.h:432:
+#define iosys_map_rd_field(map__, struct_offset__, struct_type__, field__) ({ \
+ struct_type__ *s; \
+ iosys_map_rd(map__, struct_offset__ + offsetof(struct_type__, field__), \
+ typeof(s->field__)); \
+})

-:258: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'field__' - possible side-effects?
#258: FILE: include/linux/iosys-map.h:432:
+#define iosys_map_rd_field(map__, struct_offset__, struct_type__, field__) ({ \
+ struct_type__ *s; \
+ iosys_map_rd(map__, struct_offset__ + offsetof(struct_type__, field__), \
+ typeof(s->field__)); \
+})

-:279: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'struct_offset__' may be better as '(struct_offset__)' to avoid precedence issues
#279: FILE: include/linux/iosys-map.h:453:
+#define iosys_map_wr_field(map__, struct_offset__, struct_type__, field__, val__) ({ \
+ struct_type__ *s; \
+ iosys_map_wr(map__, struct_offset__ + offsetof(struct_type__, field__), \
+ typeof(s->field__), val__); \
+})

-:279: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'struct_type__' may be better as '(struct_type__)' to avoid precedence issues
#279: FILE: include/linux/iosys-map.h:453:
+#define iosys_map_wr_field(map__, struct_offset__, struct_type__, field__, val__) ({ \
+ struct_type__ *s; \
+ iosys_map_wr(map__, struct_offset__ + offsetof(struct_type__, field__), \
+ typeof(s->field__), val__); \
+})

-:279: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'field__' - possible side-effects?
#279: FILE: include/linux/iosys-map.h:453:
+#define iosys_map_wr_field(map__, struct_offset__, struct_type__, field__, val__) ({ \
+ struct_type__ *s; \
+ iosys_map_wr(map__, struct_offset__ + offsetof(struct_type__, field__), \
+ typeof(s->field__), val__); \
+})

total: 0 errors, 0 warnings, 7 checks, 217 lines checked
5aed3fa10ede drm/i915/gt: Add helper for shmem copy to iosys_map
f7aaba839570 drm/i915/guc: Keep iosys_map of ads_blob around
4156cb519230 drm/i915/guc: Add read/write helpers for ADS blob
e71bbda4bf0f drm/i915/guc: Convert golden context init to iosys_map
49375cce81e4 drm/i915/guc: Convert policies update to iosys_map
234c1edc8ec8 drm/i915/guc: Convert engine record to iosys_map
13c3dafcbb9c drm/i915/guc: Convert guc_ads_private_data_reset to iosys_map
e2af5d8aae81 drm/i915/guc: Convert golden context prep to iosys_map
0a9faaccb3d3 drm/i915/guc: Replace check for golden context size
6518310edc43 drm/i915/guc: Convert mapping table to iosys_map
cd0f41c2e8ba drm/i915/guc: Convert capture list to iosys_map
dea23b4eadd0 drm/i915/guc: Convert guc_mmio_reg_state_init to iosys_map
62befe7c758b drm/i915/guc: Convert __guc_ads_init to iosys_map
-:42: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#42: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c:623:
+ ads_blob_write(guc, system_info.generic_gt_sysinfo[GUC_GENERIC_GT_SYSINFO_VDBOX_SFC_SUPPORT_MASK],

-:52: WARNING:LONG_LINE: line length of 111 exceeds 100 columns
#52: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ads.c:630:
+ system_info.generic_gt_sysinfo[GUC_GENERIC_GT_SYSINFO_DOORBELL_COUNT_PER_SQIDI],

total: 0 errors, 2 warnings, 0 checks, 52 lines checked
107e7bba4a41 drm/i915/guc: Remove plain ads_blob pointer