From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AE90CC433F5 for ; Wed, 20 Apr 2022 06:31:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D3D2C10F190; Wed, 20 Apr 2022 06:31:12 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 07E3110F190; Wed, 20 Apr 2022 06:31:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650436271; x=1681972271; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=4jR3EFxRFOzturlFugVQAcZ+IFecgSENuMS8nkVcJMM=; b=fz1pQatXiKN+BIWjOhM21RiQIe4JAnjuZj3pt6yp5O/oxcmslFIVm8Xq 98weWfHYSEm4V1qFTW9GAYf24U4hNRxHAgKOQ7W+ahJqTXjMM/0k4DnFL 1SllEJvWgbKo728OooO4wT0vmyssK37J91+1a6Fw22MAw7LDY3zf81mMy 8Pb+IZ/J356p519Awu9tObFtOT1Fl+2wrTCXZsJod0bELqb9MHT5gZTnf xP5fGUxb1N5ib9tAl9i0MWRc/5n46vnCzRnVhAUOUu/cXPIhCzieZyUxJ d6yFCE8waA7cC30ysjHfLIaViA3FZTmpmJHgA0cMTHMhCAo8Af+XxVD2G w==; X-IronPort-AV: E=McAfee;i="6400,9594,10322"; a="263715860" X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; d="scan'208";a="263715860" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2022 23:31:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,274,1643702400"; d="scan'208";a="531356066" Received: from lkp-server01.sh.intel.com (HELO 3abc53900bec) ([10.239.97.150]) by orsmga002.jf.intel.com with ESMTP; 19 Apr 2022 23:31:08 -0700 Received: from kbuild by 3abc53900bec with local (Exim 4.95) (envelope-from ) id 1nh3rn-0006fW-Cc; Wed, 20 Apr 2022 06:31:07 +0000 Date: Wed, 20 Apr 2022 14:30:45 +0800 From: kernel test robot To: Karol Herbst , linux-kernel@vger.kernel.org Message-ID: <202204201422.5Bu5aV2Z-lkp@intel.com> References: <20220419234436.2638649-1-kherbst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220419234436.2638649-1-kherbst@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix race in __i915_vma_remove_closed X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, kbuild-all@lists.01.org, Karol Herbst , dri-devel@lists.freedesktop.org, Chris Wilson Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi Karol, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on linus/master v5.18-rc3 next-20220419] [cannot apply to drm-intel/for-linux-next linux/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/intel-lab-lkp/linux/commits/Karol-Herbst/drm-i915-Fix-race-in-__i915_vma_remove_closed/20220420-074525 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip config: x86_64-randconfig-a011 (https://download.01.org/0day-ci/archive/20220420/202204201422.5Bu5aV2Z-lkp@intel.com/config) compiler: gcc-11 (Debian 11.2.0-20) 11.2.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/50a17180127b7d2527ee9a8f5c9e8207e158afb6 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Karol-Herbst/drm-i915-Fix-race-in-__i915_vma_remove_closed/20220420-074525 git checkout 50a17180127b7d2527ee9a8f5c9e8207e158afb6 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/i915/ If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All warnings (new ones prefixed by >>): drivers/gpu/drm/i915/i915_vma.c: In function 'release_references': >> drivers/gpu/drm/i915/i915_vma.c:1654:9: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] 1654 | struct intel_gt *gt = vma->vm->gt; | ^~~~~~ vim +1654 drivers/gpu/drm/i915/i915_vma.c 1640 1641 static void release_references(struct i915_vma *vma, bool vm_ddestroy) 1642 { 1643 struct drm_i915_gem_object *obj = vma->obj; 1644 1645 GEM_BUG_ON(i915_vma_is_active(vma)); 1646 1647 spin_lock(&obj->vma.lock); 1648 list_del(&vma->obj_link); 1649 if (!RB_EMPTY_NODE(&vma->obj_node)) 1650 rb_erase(&vma->obj_node, &obj->vma.tree); 1651 1652 spin_unlock(&obj->vma.lock); 1653 > 1654 struct intel_gt *gt = vma->vm->gt; 1655 1656 spin_lock_irq(>->closed_lock); 1657 __i915_vma_remove_closed(vma); 1658 spin_unlock_irq(>->closed_lock); 1659 1660 if (vm_ddestroy) 1661 i915_vm_resv_put(vma->vm); 1662 1663 i915_active_fini(&vma->active); 1664 GEM_WARN_ON(vma->resource); 1665 i915_vma_free(vma); 1666 } 1667 -- 0-DAY CI Kernel Test Service https://01.org/lkp