From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D9D7C433EF for ; Thu, 21 Apr 2022 08:31:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D90C110F84C; Thu, 21 Apr 2022 08:31:23 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2F99D10F84B; Thu, 21 Apr 2022 08:31:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1650529883; x=1682065883; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=zzNvirlYkkziTJvdx2DHiWBsxoMsvkMgSyNBQkhFE5M=; b=lyGFbJUtmjCCeHh2+obrTcbTX67DDspQD0M+knGFU3h1spUQedUiAya5 4/JbogqwMem7ovdUcPRJ3/8P+2Bqv68EDUX5wKk2dxxa0Kd8rKa2hFbn1 qMaqePa1u0XRPxnKkAgd4HF3pYn5O5D3jea9kT1uw7uN59qVNtwfk9GSk 6X3fno/njnA6A1s+VcMhzdXBjmbK59cjUIxfAsgj0ujFfCrTB7Vi4L65M RQcFw0IwDoDK5/mgjtHcJ5vynhQzvanT1wm8cxyesWyepIn1eVq5ZorPh uRgZj8C5wkCH5Bx+0H5YAB1yrAMBMyhS7pMqz5JwJKWvPDRNcYqxl1vLh w==; X-IronPort-AV: E=McAfee;i="6400,9594,10323"; a="289393932" X-IronPort-AV: E=Sophos;i="5.90,278,1643702400"; d="scan'208";a="289393932" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2022 01:31:22 -0700 X-IronPort-AV: E=Sophos;i="5.90,278,1643702400"; d="scan'208";a="530179930" Received: from ramaling-i9x.iind.intel.com (HELO intel.com) ([10.203.144.108]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2022 01:31:20 -0700 Date: Thu, 21 Apr 2022 14:02:14 +0530 From: Ramalingam C To: Matthew Auld Message-ID: <20220421083214.GC18679@intel.com> References: <20220420181613.70033-1-matthew.auld@intel.com> <20220420181613.70033-3-matthew.auld@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220420181613.70033-3-matthew.auld@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [CI 3/4] drm/i915/selftests: fixup min_alignment usage X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas =?utf-8?Q?Hellstr=C3=B6m?= , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 2022-04-20 at 19:16:12 +0100, Matthew Auld wrote: > Trying to cast the region id into the region type doesn't work too well, > since the i915_vm_min_alignment() won't give us the correct value for > the stolen-lmem case. > > Signed-off-by: Matthew Auld Looks good to me. Reviewed-by: Ramalingam C > Cc: Thomas Hellström > Cc: Nirmoy Das > Cc: Ramalingam C > --- > drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > index 5c9bfa409ff5..bccc49a8ab5e 100644 > --- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > +++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c > @@ -1150,7 +1150,7 @@ static int misaligned_pin(struct i915_address_space *vm, > flags |= PIN_GLOBAL; > > for_each_memory_region(mr, vm->i915, id) { > - u64 min_alignment = i915_vm_min_alignment(vm, (enum intel_memory_type)id); > + u64 min_alignment = i915_vm_min_alignment(vm, mr->type); > u64 size = min_alignment; > u64 addr = round_down(hole_start + (hole_size / 2), min_alignment); > > -- > 2.34.1 >