Re: [Intel-gfx] [PATCH] i915/pmu: Wire GuC backend to per-client busyness

Umesh Nerlige Ramappa
2022-08-26T15:45:16Z

On Wed, Aug 24, 2022 at 06:17:19PM -0700, Dixit, Ashutosh wrote:
>On Fri, 05 Aug 2022 08:18:48 -0700, Umesh Nerlige Ramappa wrote:
>>
>> On Fri, Aug 05, 2022 at 10:45:30AM +0100, Tvrtko Ursulin wrote:
>> >
>> > On 05/08/2022 00:21, Umesh Nerlige Ramappa wrote:
>> >> -static inline struct intel_guc *ce_to_guc(struct intel_context *ce)
>> >> +static inline struct intel_guc *ce_to_guc(const struct intel_context *ce)
>> >
>> > This is odd since the helper now takes away constness. I can't really
>> > figure out why the change is needed?
>
>Hi Umesh, I am also wondering about this, I think you missed answering this
>question from Tvrtko.

This helper 'adds' constness, so wasn't sure if the comment was intended
for this helper.

Thanks,
Umesh

>
>Thanks.
>--
>Ashutosh