Re: [Intel-gfx] [PULL] gvt-fixes

Jani Nikula
2022-08-18T10:16:06Z

On Wed, 17 Aug 2022, "Colin King (gmail)" <colin.i.king@gmail.com> wrote:
> On 17/08/2022 21:07, Vivi, Rodrigo wrote:
>> On Tue, 2022-08-16 at 12:43 +0800, Zhenyu Wang wrote:
>>> On 2022.08.16 12:05:08 +0800, Zhenyu Wang wrote:
>>>> On 2022.08.15 19:32:45 -0400, Rodrigo Vivi wrote:
>>>>> On Mon, Aug 15, 2022 at 10:38:55AM +0800, Zhenyu Wang wrote:
>>> oh, surprise! I just found Colin's email is actually defined in
>>> .mailmap,
>>> so all his commits in kernel are changed for @intel.com address as in
>>> mailmap...
>>
>> Colin, would you mind to get the Sign-off-by in the patches the same
>> as your authorship so the tools don't get confused?
>> (starting with modifying in tree this already merged patch)
>
> Since my patches are generally trivial janitorial fixed done in my spare
> time I'm going to get the .mailmap changed to use my gmail email address
> rather than my Intel one (since I don't do kernel work in my current role).
>
> This should clean up the confusion. Apologies.

Everyone hold your horses.

I think our tooling should handle the mailmap stuff. The commit *is*
fine, it's just that the when we check it, we let mailmap alter it. We
should check the commit without mailmap modifications.

BR,
Jani.

--
Jani Nikula, Intel Open Source Graphics Center