Re: [Intel-gfx] [PATCH 01/19] drm/i915/perf: Fix OA filtering logic for GuC mode

Umesh Nerlige Ramappa
2022-09-14T23:38:00Z

On Mon, Sep 12, 2022 at 08:08:33PM -0700, Dixit, Ashutosh wrote:
>On Fri, 09 Sep 2022 16:47:36 -0700, Dixit, Ashutosh wrote:
>>
>> On Tue, 23 Aug 2022 13:41:37 -0700, Umesh Nerlige Ramappa wrote:
>> >
>>
>> Hi Umesh,
>>
>> > With GuC mode of submission, GuC is in control of defining the context id field
>> > that is part of the OA reports. To filter reports, UMD and KMD must know what sw
>> > context id was chosen by GuC. There is not interface between KMD and GuC to
>> > determine this, so read the upper-dword of EXECLIST_STATUS to filter/squash OA
>> > reports for the specific context.
>>
>> Do you think it is worth defining an interface for GuC to return the sw
>> ctx_id it will be using for a ctx, say at ctx registration time?
>
>Umesh, I came across these in GuC documentation:
>
>guc_pcv1_context_parameters_set_h2g_data_t::context_id
>guc_pcv2_context_parameters_set_h2g_data_t::context_id
>
>Also in the code we have in prepare_context_registration_info_v70 'ctx_id =
>ce->guc_id.id' which seems to be assigned in new_guc_id. So wondering if
>this is what we need and we already have it?

this id is different from what GuC programs into the lrca.

Thanks,
Umesh
>
>Thanks.
>--
>Ashutosh