Re: [Intel-gfx] [PATCH 07/19] drm/i915/perf: Simply use stream->ctx

Lionel Landwerlin
2022-09-06T19:53:16Z

On 23/08/2022 23:41, Umesh Nerlige Ramappa wrote:
> Earlier code used exclusive_stream to check for user passed context.
> Simplify this by accessing stream->ctx.
>
> Signed-off-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> ---
> drivers/gpu/drm/i915/i915_perf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> index bbf1c574f393..3e3bda147c48 100644
> --- a/drivers/gpu/drm/i915/i915_perf.c
> +++ b/drivers/gpu/drm/i915/i915_perf.c
> @@ -801,7 +801,7 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
> * switches since it's not-uncommon for periodic samples to
> * identify a switch before any 'context switch' report.
> */
> - if (!stream->perf->exclusive_stream->ctx ||
> + if (!stream->ctx ||
> stream->specific_ctx_id == ctx_id ||
> stream->oa_buffer.last_ctx_id == stream->specific_ctx_id ||
> reason & OAREPORT_REASON_CTX_SWITCH) {
> @@ -810,7 +810,7 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
> * While filtering for a single context we avoid
> * leaking the IDs of other contexts.
> */
> - if (stream->perf->exclusive_stream->ctx &&
> + if (stream->ctx &&
> stream->specific_ctx_id != ctx_id) {
> report32[2] = INVALID_CTX_ID;
> }