Re: [Intel-gfx] [PATCH 5/8] drm/i915: Rename and expose common GT early init routine

Sripada, Radhakrishna
2022-08-31T00:34:06Z

> -----Original Message-----
> From: Roper, Matthew D <matthew.d.roper@intel.com>
> Sent: Monday, August 29, 2022 10:03 AM
> To: intel-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org; Sripada, Radhakrishna
> <radhakrishna.sripada@intel.com>; Roper, Matthew D
> <matthew.d.roper@intel.com>
> Subject: [PATCH 5/8] drm/i915: Rename and expose common GT early init
> routine
>
> The common early GT init is needed for initialization of all GT types
> (root/primary, remote tile, standalone media). Since standalone media
> (coming in the next patch) will be implemented in a separate file,
> rename and expose the function for use.
>
Reviewed-by: Radhakrishna Sripada <Radhakrishna.sripada@intel.com>

- RK Sripada
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_gt.c | 6 +++---
> drivers/gpu/drm/i915/gt/intel_gt.h | 1 +
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c
> b/drivers/gpu/drm/i915/gt/intel_gt.c
> index 7c0525e96155..d21ec11346a5 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt.c
> @@ -35,7 +35,7 @@
> #include "intel_uncore.h"
> #include "shmem_utils.h"
>
> -static void __intel_gt_init_early(struct intel_gt *gt)
> +void intel_gt_common_init_early(struct intel_gt *gt)
> {
> spin_lock_init(&gt->irq_lock);
>
> @@ -65,7 +65,7 @@ void intel_root_gt_init_early(struct drm_i915_private
> *i915)
> gt->i915 = i915;
> gt->uncore = &i915->uncore;
>
> - __intel_gt_init_early(gt);
> + intel_gt_common_init_early(gt);
> }
>
> static int intel_gt_probe_lmem(struct intel_gt *gt)
> @@ -789,7 +789,7 @@ static int intel_gt_tile_setup(struct intel_gt *gt,
> phys_addr_t phys_addr)
>
> gt->uncore = uncore;
>
> - __intel_gt_init_early(gt);
> + intel_gt_common_init_early(gt);
> }
>
> intel_uncore_init_early(gt->uncore, gt);
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt.h
> b/drivers/gpu/drm/i915/gt/intel_gt.h
> index 4d8779529cc2..c9a359f35d0f 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt.h
> @@ -44,6 +44,7 @@ static inline struct intel_gt *gsc_to_gt(struct intel_gsc
> *gsc)
> return container_of(gsc, struct intel_gt, gsc);
> }
>
> +void intel_gt_common_init_early(struct intel_gt *gt);
> void intel_root_gt_init_early(struct drm_i915_private *i915);
> int intel_gt_assign_ggtt(struct intel_gt *gt);
> int intel_gt_init_mmio(struct intel_gt *gt);
> --
> 2.37.2