[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: Add "standalone media" support for MTL

Patchwork
2022-08-29T20:28:15Z

== Series Details ==

Series: i915: Add "standalone media" support for MTL
URL : https://patchwork.freedesktop.org/series/107908/
State : warning

== Summary ==

Error: dim checkpatch failed
2d07e36f0a4f drm/i915: Move locking and unclaimed check into mmio_debug_{suspend, resume}
943c8e30fc24 drm/i915: Only hook up uncore->debug for primary uncore
005c7f1709b6 drm/i915: Use managed allocations for extra uncore objects
001d8b25313a drm/i915: Prepare more multi-GT initialization
-:70: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "gtdef->setup"
#70: FILE: drivers/gpu/drm/i915/gt/intel_gt.c:842:
+ gtdef->setup != NULL;

total: 0 errors, 0 warnings, 1 checks, 142 lines checked
6e44c6e54b94 drm/i915: Rename and expose common GT early init routine
2c5537309641 drm/i915/xelpmp: Expose media as another GT
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:83: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#83:
new file mode 100644

-:119: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!uncore->regs"
#119: FILE: drivers/gpu/drm/i915/gt/intel_sa_media.c:32:
+ if (drm_WARN_ON(&i915->drm, uncore->regs == NULL))

total: 0 errors, 1 warnings, 1 checks, 233 lines checked
06eba434c957 drm/i915/mtl: Use primary GT's irq lock for media GT
-:81: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#81: FILE: drivers/gpu/drm/i915/gt/intel_gt.c:795:
+ spinlock_t *irq_lock;

-:227: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#227: FILE: drivers/gpu/drm/i915/gt/intel_gt_types.h:160:
+ spinlock_t *irq_lock;

total: 0 errors, 0 warnings, 2 checks, 459 lines checked
3be80c873513 drm/i915/mtl: Hook up interrupts for standalone media