Re: [Intel-gfx] [PATCH v6 32/57] nouveau: adapt NV_DEBUG, NV_ATOMIC to use DRM.debug

Timur Tabi
2023-03-20T13:19:39Z

On Sun, Sep 4, 2022 at 4:48 PM Jim Cromie <jim.cromie@gmail.com> wrote:
>
> These 2 macros used drm_debug_enabled() on DRM_UT_{DRIVER,ATOMIC}
> respectively, replace those with drm_dbg_##cat invocations.
>
> this results in new class'd prdbg callsites:
>
> :#> grep nouveau /proc/dynamic_debug/control | grep class | wc
> 116 1130 15584
> :#> grep nouveau /proc/dynamic_debug/control | grep class | grep DRIVER | wc
> 74 704 9709
> :#> grep nouveau /proc/dynamic_debug/control | grep class | grep ATOMIC | wc
> 31 307 4237
> :#> grep nouveau /proc/dynamic_debug/control | grep class | grep KMS | wc
> 11 119 1638
>
> the KMS entries are due to existing uses of drm_dbg_kms().
>
> Signed-off-by: Jim Cromie <jim.cromie@gmail.com>

Has this patch set been forgotten? It was posted six months ago and
there's no sign that it was picked up.

The changes to drm_debug_enabled have impacted NV_DEBUG and NV_ATOMIC
and something needs to be fixed. I posted a simpler patch a few weeks
ago, but maybe Jim's is better.