From: Arun R Murthy <arun.r.murthy@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers
Date: Tue, 6 Sep 2022 09:48:06 +0530 [thread overview]
Message-ID: <20220906041806.4095575-1-arun.r.murthy@intel.com> (raw)
In-Reply-To: <20220906034803.4094252-1-arun.r.murthy@intel.com>
Starting from Gen12 Async Flip is supported on linear buffers.
This patch enables support for async on linear buffer.
UseCase: In Hybrid graphics, for hardware unsupported pixel formats it
will be converted to linear memory and then composed.
v2: Added use case
v3: Added FIXME for ICL indicating the restrictions
Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index be7cff722196..f0d2c3cb3bd5 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -6610,6 +6610,20 @@ static int intel_async_flip_check_hw(struct intel_atomic_state *state, struct in
* this selectively if required.
*/
switch (new_plane_state->hw.fb->modifier) {
+ case DRM_FORMAT_MOD_LINEAR:
+ /*
+ * FIXME: Async on Linear buffer is supported on ICL as
+ * but with additional alignment and fbc restrictions
+ * need to be taken care of. These aren't applicable for
+ * gen12+.
+ */
+ if (DISPLAY_VER(i915) < 12) {
+ drm_dbg_kms(&i915->drm,
+ "[PLANE:%d:%s] Modifier does not support async flips\n",
+ plane->base.base.id, plane->base.name);
+ return -EINVAL;
+ }
+
case I915_FORMAT_MOD_X_TILED:
case I915_FORMAT_MOD_Y_TILED:
case I915_FORMAT_MOD_Yf_TILED:
--
2.25.1
next prev parent reply other threads:[~2022-09-06 4:18 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 12:04 [Intel-gfx] [PATCH] drm/i915: Support Async Flip on Linear buffers Arun R Murthy
2022-04-26 12:37 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-04-26 13:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-04-26 14:36 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-04-26 18:15 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2022-04-27 2:58 ` Murthy, Arun R
2022-04-27 11:58 ` Ville Syrjälä
2022-04-28 5:35 ` Murthy, Arun R
2022-05-05 6:33 ` Murthy, Arun R
2022-05-05 14:26 ` Ville Syrjälä
2022-05-05 16:09 ` Murthy, Arun R
2022-05-05 19:22 ` Ville Syrjälä
2022-04-26 23:00 ` kernel test robot
2022-04-27 3:04 ` kernel test robot
2022-06-01 4:24 ` [Intel-gfx] [PATCH v2] " Arun R Murthy
2022-06-14 9:40 ` Murthy, Arun R
2022-06-30 11:57 ` Murthy, Arun R
2022-06-30 12:25 ` Ville Syrjälä
2022-06-30 12:41 ` Murthy, Arun R
2022-06-01 5:21 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Support Async Flip on Linear buffers (rev2) Patchwork
2022-06-01 5:43 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-06-01 6:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-07-04 16:15 ` [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers Arun R Murthy
2022-08-22 3:36 ` Murthy, Arun R
2022-08-23 12:57 ` Ville Syrjälä
2022-08-24 3:02 ` Murthy, Arun R
2022-08-24 12:17 ` Ville Syrjälä
2022-08-30 6:15 ` Murthy, Arun R
2022-08-30 7:45 ` Ville Syrjälä
2022-08-30 7:57 ` Murthy, Arun R
2022-08-30 8:09 ` Ville Syrjälä
2022-07-04 21:01 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Support Async Flip on Linear buffers (rev3) Patchwork
2022-07-05 2:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-09-06 3:48 ` [Intel-gfx] [PATCHv3] drm/i915: Support Async Flip on Linear buffers Arun R Murthy
2022-09-06 4:18 ` Arun R Murthy [this message]
2023-03-13 9:30 ` Lisovskiy, Stanislav
2023-03-14 5:21 ` Murthy, Arun R
2022-09-09 3:46 ` Murthy, Arun R
2022-09-14 10:50 ` Murthy, Arun R
2022-09-19 5:08 ` Murthy, Arun R
2022-10-10 7:53 ` Murthy, Arun R
2022-10-28 3:23 ` Murthy, Arun R
2022-10-28 6:31 ` Ville Syrjälä
2022-12-05 3:53 ` Murthy, Arun R
2023-01-13 7:26 ` Murthy, Arun R
2023-01-17 8:39 ` Murthy, Arun R
2023-01-23 6:43 ` Murthy, Arun R
2023-02-02 6:51 ` Murthy, Arun R
2023-02-02 9:24 ` Ville Syrjälä
2023-02-02 11:28 ` Murthy, Arun R
2023-02-07 5:51 ` Murthy, Arun R
2022-09-06 4:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Support Async Flip on Linear buffers (rev4) Patchwork
2022-09-06 4:17 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-09-06 5:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Support Async Flip on Linear buffers (rev5) Patchwork
2022-09-06 5:20 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Support Async Flip on Linear buffers (rev4) Patchwork
2022-09-06 6:08 ` [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Support Async Flip on Linear buffers (rev5) Patchwork
2022-11-21 7:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Support Async Flip on Linear buffers (rev6) Patchwork
2022-11-21 9:22 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220906041806.4095575-1-arun.r.murthy@intel.com \
--to=arun.r.murthy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).