From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28484ECAAA1 for ; Mon, 31 Oct 2022 22:53:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DEF6C10E1E6; Mon, 31 Oct 2022 22:53:20 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1B2C610E1E6 for ; Mon, 31 Oct 2022 22:53:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1667256796; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bHpC1zf1qV1jmlc1wntYS1OKLTiiLa4Edpg3f0kbUyY=; b=BN+EvRRauibQvs3QghlcOMA5pe5ImWI5cEWd7QybddMNxesYL4CaSpebsOAmomxq+/mB7/ 3s2O/DNzba+UPTrsdpDQ5wb+q7FHhFSFz5199z3lEZrtONUodBbfoZRBxqsGkReZ+BDQUp LWO6ZFL5YEgD5CzvgLxgVboO1WWxvyE= Received: from mail-il1-f200.google.com (mail-il1-f200.google.com [209.85.166.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-564-Ob-NsJGAO8C_aR916iWcOQ-1; Mon, 31 Oct 2022 18:53:14 -0400 X-MC-Unique: Ob-NsJGAO8C_aR916iWcOQ-1 Received: by mail-il1-f200.google.com with SMTP id w13-20020a056e021c8d00b00300ad5b16a0so3275658ill.7 for ; Mon, 31 Oct 2022 15:53:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bHpC1zf1qV1jmlc1wntYS1OKLTiiLa4Edpg3f0kbUyY=; b=prmb60fnIUr5AqIYaCAZ12M0zdtBB2mVsZtfNn+FWPecrYAkK8Ueqtv7+QyXpWBgxu 2IayhYFP/gmHxzvzIJHmScZ86C2nkfawNaSOl8+BIF3wH6sDXQhJe8vRXvnvaNh7OJb2 BBt3VKPHfZbpTG+me+6xjT0lc73+TYzKhr/Of17CK0+jPY8PtYqTU9kwn4TPCd2ql+Qq 6RiMjlCoft1rnDPE7hcHSeYfOqNcnz9KCogT1GfXOKlBmfPT0azy93oz2RNQeMY6Zy5k 3zgCRQ/sPA6xU9S++yYyCPoAWRjMNAGSHoGsLNK2d8FvoeztBUPzlQve/4ieUNMxc87G sOzQ== X-Gm-Message-State: ACrzQf3M8qPajLESMhGb+CnlsY8wfRQiiKolxgZBJ/RtyreCTtN+c9Lt ywz86HTGHAULK59g42At74wkwbi1FjMRvdq9uE7gRxdThOTlCv3AQuu1AdlUGVcvspdNOWo40vP 4GTKXa4dVe6P8Hh6NeLm/uRJ5xPM1 X-Received: by 2002:a05:6e02:180c:b0:2fc:4018:9440 with SMTP id a12-20020a056e02180c00b002fc40189440mr7991816ilv.225.1667256793694; Mon, 31 Oct 2022 15:53:13 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7liCEme2wsc4XzJa+HajVmv1KVpsxVcMQII15KI4qdQbhYdKRKQskOMruD/YfHk1W7Cq0evQ== X-Received: by 2002:a05:6e02:180c:b0:2fc:4018:9440 with SMTP id a12-20020a056e02180c00b002fc40189440mr7991769ilv.225.1667256793463; Mon, 31 Oct 2022 15:53:13 -0700 (PDT) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id g15-20020a02850f000000b00372bbd04b75sm3200984jai.87.2022.10.31.15.53.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 15:53:12 -0700 (PDT) Date: Mon, 31 Oct 2022 16:53:11 -0600 From: Alex Williamson To: Jason Gunthorpe Message-ID: <20221031165311.0698e1ea.alex.williamson@redhat.com> In-Reply-To: References: <0-v1-4991695894d8+211-vfio_iommufd_jgg@nvidia.com> <10-v1-4991695894d8+211-vfio_iommufd_jgg@nvidia.com> <20221026153133.44dc05c8.alex.williamson@redhat.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.34; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH 10/10] iommufd: Allow iommufd to supply /dev/vfio/vfio X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, dri-devel@lists.freedesktop.org, Vineeth Vijayan , Diana Craciun , Alexander Gordeev , David Airlie , Longfang Liu , linux-s390@vger.kernel.org, Yi Liu , Matthew Rosato , Will Deacon , Joerg Roedel , Halil Pasic , iommu@lists.linux.dev, Nicolin Chen , Christian Borntraeger , intel-gfx@lists.freedesktop.org, Jason Herne , Eric Farman , Vasily Gorbik , Heiko Carstens , Eric Auger , Harald Freudenberger , Rodrigo Vivi , intel-gvt-dev@lists.freedesktop.org, Tony Krowiak , Yishai Hadas , Cornelia Huck , Peter Oberparleiter , Shameer Kolothum , Sven Schnelle , Daniel Vetter , Robin Murphy , Lu Baolu Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, 28 Oct 2022 15:44:36 -0300 Jason Gunthorpe wrote: > On Wed, Oct 26, 2022 at 03:31:33PM -0600, Alex Williamson wrote: > > On Tue, 25 Oct 2022 15:50:45 -0300 > > Jason Gunthorpe wrote: > > > > > If the VFIO container is compiled out, give a kconfig option for iommufd > > > to provide the miscdev node with the same name and permissions as vfio > > > uses. > > > > > > The compatibility node supports the same ioctls as VFIO and automatically > > > enables the VFIO compatible pinned page accounting mode. > > > > I think I'd like to see some sort of breadcrumb when /dev/vfio/vfio is > > provided by something other than the vfio container code. If we intend > > to include this before P2P is resolved, that breadcrumb > > I don't belive I can get P2P done soon enough. I plan to do it after > this is merged. Right now these two series are taking all my time. > > > (dmesg I'm guessing) might also list any known limitations of the > > compatibility to save time with debugging. Thanks, > > Yes, that makes sense. > > Do you want a dmesg at module load time, on every open, or a sysfs > something? What seems like it would make it into a bug report? I think dmesg at module load time should probably be ok, every open seems like harassment and sysfs would require updated support in various bug reporting tools. Users are often terrible about reporting full dmesg in bugs, but they do often filter it for "IOMMU" or "VFIO", so keep that in mind when crafting the log message. Thanks, Alex