Hi Arun, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-tip/drm-tip] url: https://github.com/intel-lab-lkp/linux/commits/Arun-R-Murthy/drm-i915-fbc-Disable-FBC-when-VT-d-is-enabled-for-Gen9/20221121-172027 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link: https://lore.kernel.org/r/20221121091855.3562288-1-arun.r.murthy%40intel.com patch subject: [Intel-gfx] [PATCH] drm/i915/fbc: Disable FBC when VT-d is enabled for Gen9 config: i386-randconfig-a015-20221121 compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/61ba49ddf3c6cae1717955273c865563fd7afe87 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Arun-R-Murthy/drm-i915-fbc-Disable-FBC-when-VT-d-is-enabled-for-Gen9/20221121-172027 git checkout 61ba49ddf3c6cae1717955273c865563fd7afe87 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): drivers/gpu/drm/i915/display/intel_fbc.c: In function 'need_fbc_vtd_wa': >> drivers/gpu/drm/i915/display/intel_fbc.c:1656:35: error: suggest parentheses around '&&' within '||' [-Werror=parentheses] 1656 | if (i915_vtd_active(i915) && | ~~~~~~~~~~~~~~~~~~~~~~^~ 1657 | (DISPLAY_VER(i915) == 9) || DISPLAY_VER(i915) == 10) { | ~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors vim +1656 drivers/gpu/drm/i915/display/intel_fbc.c 80788a0fbbdfbb1 drivers/gpu/drm/i915/intel_fbc.c Paulo Zanoni 2016-04-13 1652 d061882344279eb drivers/gpu/drm/i915/display/intel_fbc.c Ville Syrjälä 2021-11-04 1653 static bool need_fbc_vtd_wa(struct drm_i915_private *i915) 36dbc4d76918d75 drivers/gpu/drm/i915/intel_fbc.c Chris Wilson 2016-08-04 1654 { 61ba49ddf3c6cae drivers/gpu/drm/i915/display/intel_fbc.c Arun R Murthy 2022-11-21 1655 /* WaFbcTurnOffFbcWhenHyperVisorIsUsed:skl,bxt,cnl,kbl */ a7f46d5b91a5eb0 drivers/gpu/drm/i915/display/intel_fbc.c Tvrtko Ursulin 2022-03-29 @1656 if (i915_vtd_active(i915) && 61ba49ddf3c6cae drivers/gpu/drm/i915/display/intel_fbc.c Arun R Murthy 2022-11-21 1657 (DISPLAY_VER(i915) == 9) || DISPLAY_VER(i915) == 10) { d061882344279eb drivers/gpu/drm/i915/display/intel_fbc.c Ville Syrjälä 2021-11-04 1658 drm_info(&i915->drm, 97ed48b5c8b1487 drivers/gpu/drm/i915/display/intel_fbc.c Wambui Karuga 2020-03-10 1659 "Disabling framebuffer compression (FBC) to prevent screen flicker with VT-d enabled\n"); 36dbc4d76918d75 drivers/gpu/drm/i915/intel_fbc.c Chris Wilson 2016-08-04 1660 return true; 36dbc4d76918d75 drivers/gpu/drm/i915/intel_fbc.c Chris Wilson 2016-08-04 1661 } 36dbc4d76918d75 drivers/gpu/drm/i915/intel_fbc.c Chris Wilson 2016-08-04 1662 36dbc4d76918d75 drivers/gpu/drm/i915/intel_fbc.c Chris Wilson 2016-08-04 1663 return false; 36dbc4d76918d75 drivers/gpu/drm/i915/intel_fbc.c Chris Wilson 2016-08-04 1664 } 36dbc4d76918d75 drivers/gpu/drm/i915/intel_fbc.c Chris Wilson 2016-08-04 1665 -- 0-DAY CI Kernel Test Service https://01.org/lkp