From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1611C4332F for ; Wed, 14 Dec 2022 16:21:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A69FB10E430; Wed, 14 Dec 2022 16:21:37 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 62FBA10E430; Wed, 14 Dec 2022 16:21:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671034894; x=1702570894; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=sugwmwrUIAbwUVd9kUUcbnqMzWklglljdUgzpTG789o=; b=lahGrUkUD0Z7+QLr7Q/N3kJuQextTU1sjp1H1Ej60c+3QEwSf9Vwy8WI dRz9RynL6Yt6Am7L8oFsBM3+aI/rIcbphx+CqHwt9amt9VlEGje5/cNwW y1VOtEu1T+5Mv2HUkjAjmtEmGEGVERuUSp2jR95Lh4nDImiriMP6TBo7Q SYoOCHcIJyjiTZMfejPOtlA7AO3CFQCtC4G1vQkTYVnpRxmwmL4Cq6VHd xQSbFNgSMe3/MJ6tF6ExwHXQLr7m6YIiGgQR2IRzmFxkBC3xm9c3ubpAd JvXI+aSMa5srGEfwUhzuiGMv69J07M4zHp4xpr7NFZlwqTXXesHXAjBkZ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="404716283" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="404716283" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 08:21:33 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10561"; a="642559944" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="642559944" Received: from joe-255.igk.intel.com (HELO localhost) ([172.22.229.67]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 08:21:20 -0800 Date: Wed, 14 Dec 2022 17:21:17 +0100 From: Stanislaw Gruszka To: Eric Dumazet Message-ID: <20221214162117.GC1062210@linux.intel.com> References: <20221214123358.GA1062210@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-gfx] [PATCH 1/5] Renaming weak prng invocations - prandom_bytes_state, prandom_u32_state X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Jason A. Donenfeld" , Vignesh Raghavendra , Peter Zijlstra , Roman Gushchin , Rasmus Villemoes , Alexei Starovoitov , dri-devel@lists.freedesktop.org, Song Liu , linux-mtd@lists.infradead.org, Stanislav Fomichev , "H. Peter Anvin" , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Christoph Lameter , Daniel Borkmann , Richard Weinberger , x86@kernel.org, John Fastabend , Andrii Nakryiko , ilay.bahat1@gmail.com, Ingo Molnar , Jiri Pirko , David Rientjes , Yonghong Song , Paolo Abeni , intel-gfx@lists.freedesktop.org, Petr Mladek , david.keisarschm@mail.huji.ac.il, Dave Hansen , Hao Luo , Miquel Raynal , "James E.J. Bottomley" , Andrew Morton , Steven Rostedt , KP Singh , Rodrigo Vivi , Borislav Petkov , Hannes Reinecke , Andy Lutomirski , Jakub Kicinski , Thomas Gleixner , Andy Shevchenko , bpf@vger.kernel.org, Vlastimil Babka , linux-scsi@vger.kernel.org, "Martin K. Petersen" , linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Pekka Enberg , Sergey Senozhatsky , aksecurity@gmail.com, Jiri Olsa , Joonsoo Kim , Martin KaFai Lau , "David S. Miller" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Dec 14, 2022 at 04:15:49PM +0100, Eric Dumazet wrote: > On Wed, Dec 14, 2022 at 1:34 PM Stanislaw Gruszka > wrote: > > > > On Mon, Dec 12, 2022 at 03:35:20PM +0100, Jason A. Donenfeld wrote: > > > Please CC me on future revisions. > > > > > > As of 6.2, the prandom namespace is *only* for predictable randomness. > > > There's no need to rename anything. So nack on this patch 1/5. > > > > It is not obvious (for casual developers like me) that p in prandom > > stands for predictable. Some renaming would be useful IMHO. > > Renaming makes backports more complicated, because stable teams will > have to 'undo' name changes. > Stable teams are already overwhelmed by the amount of backports, and > silly merge conflicts. Since when backporting problems is valid argument for stop making changes? That's new for me. > linux kernel is not for casual readers. Sure. Regards Stanislaw