From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6EDF8C4332F for ; Mon, 19 Dec 2022 10:14:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5035C10E224; Mon, 19 Dec 2022 10:13:55 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 614E210E21C; Mon, 19 Dec 2022 10:13:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671444809; x=1702980809; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=B62nWMsZIXg2Iq7846E/qXDsSL4x0qI11dTRpOx86ok=; b=cKmBGG8ocx7xII3x6NhyCLbI8jmwXp/2Pkywy/lONkptYzXzTBK+FUeA LnksGKPbKJmjh7G79OoJf4e5WtOKMrsdjhrfCRZmsatYLqk7xVhGxiiXn fiHXcU0JgK38Ktd7cKOdAavZse09u/xy2i5CSLJIw9DIaVtLmV8Bx/qyc GHKXIyISP1nk3K8VmIgQAe4vWSbfanUHel+kFnZ8cPIvVKM2kIDugIN+9 VVI8kICWHHmGVcN1hk7BBsgoge+BGwhGCV1bXAmI86Rx/RPdaSlge9TC2 bJxTuJoe/x6NtdwNbK5sMsBfzfg+r88fmLPy0MDZGIw1ayW66FZd3N6UF w==; X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="383661585" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="383661585" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2022 02:13:29 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="713970041" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="713970041" Received: from jacahill-mobl.ger.corp.intel.com (HELO localhost.localdomain) ([10.213.235.153]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Dec 2022 02:13:27 -0800 From: Tvrtko Ursulin To: Intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Date: Mon, 19 Dec 2022 10:13:15 +0000 Message-Id: <20221219101316.168129-2-tvrtko.ursulin@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221219101316.168129-1-tvrtko.ursulin@linux.intel.com> References: <20221219101316.168129-1-tvrtko.ursulin@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Intel-gfx] [PATCH 1/2] drm/i915: Do not cover all future platforms in TLB invalidation X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Balasubramani Vivekanandan , Andrzej Hajda Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" From: Tvrtko Ursulin Revert to the original explicit approach and document the reasoning behind it. Signed-off-by: Tvrtko Ursulin Cc: Matt Roper Cc: Balasubramani Vivekanandan Cc: Andrzej Hajda --- drivers/gpu/drm/i915/gt/intel_gt.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gt.c b/drivers/gpu/drm/i915/gt/intel_gt.c index 7eeee5a7cb33..854841a731cb 100644 --- a/drivers/gpu/drm/i915/gt/intel_gt.c +++ b/drivers/gpu/drm/i915/gt/intel_gt.c @@ -1070,7 +1070,18 @@ static void mmio_invalidate_full(struct intel_gt *gt) unsigned int num = 0; unsigned long flags; - if (GRAPHICS_VER_FULL(i915) >= IP_VER(12, 50)) { + /* + * New platforms should not be added with catch-all-newer (>=) + * condition so that any later platform added triggers the below warning + * and in turn mandates a human cross-check of whether the invalidation + * flows have compatible semantics. + * + * For instance with the 11.00 -> 12.00 transition three out of five + * respective engine registers were moved to masked type. Then after the + * 12.00 -> 12.50 transition multi cast handling is required too. + */ + + if (GRAPHICS_VER_FULL(i915) == IP_VER(12, 50)) { regs = NULL; num = ARRAY_SIZE(xehp_regs); } else if (GRAPHICS_VER(i915) == 12) { -- 2.34.1