From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4989DC4332F for ; Tue, 20 Dec 2022 14:01:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9699110E058; Tue, 20 Dec 2022 14:01:18 +0000 (UTC) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6647B10E375 for ; Tue, 20 Dec 2022 14:01:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671544874; x=1703080874; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=q/S23FEjqABLFgMW7/9XJKvcSO6CrcCve4T412iUaTk=; b=nYE5zuIpE1MugSJqK40B2FEcT4FIVOReACp6bI2iJ5AGg9Yi6f9kfOWl oDQc+uzWFqAESQGtFWEfdd6dXv8CtobHzfjMia85wp/r9MJqtWAbA+aNw zvIc26wLLD97eeTU1Qjtc/zkWE8TArs59to2JPCpB0+XGwFoy7+B4lD2w FNpPHisJ7+5Ghk2bmhPXQUmPUbF7HMGjePfJR84AQrpsaVKLPasiKzEK9 EzVm1MlPwOKFgN5/X4PlCTnA/VezaUu4RlUsrxTuUWQuWxxico3+Q+hdM JFToXo5UdTmSms77Rp1Lgzb/vRTK6152h8lZUEOFORf3TsnFuwqS4/MEZ Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="318309806" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="318309806" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2022 06:01:13 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="825261027" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="825261027" Received: from spalapa-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.60.249]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2022 06:01:10 -0800 From: Jani Nikula To: intel-gfx@lists.freedesktop.org Date: Tue, 20 Dec 2022 16:01:05 +0200 Message-Id: <20221220140105.313333-1-jani.nikula@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Transfer-Encoding: 8bit Subject: [Intel-gfx] [PATCH] drm/i915/dsi: fix MIPI_BKLT_EN_1 native GPIO index X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jani.nikula@intel.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Due to copy-paste fail, MIPI_BKLT_EN_1 would always use PPS index 1, never 0. Fix the sloppiest commit in recent memory. Fixes: f087cfe6fcff ("drm/i915/dsi: add support for ICL+ native MIPI GPIO sequence") Reported-by: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c index 41f025f089d9..2cbc1292ab38 100644 --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c @@ -430,7 +430,7 @@ static void icl_native_gpio_set_value(struct drm_i915_private *dev_priv, break; case MIPI_BKLT_EN_1: case MIPI_BKLT_EN_2: - index = gpio == MIPI_AVDD_EN_1 ? 0 : 1; + index = gpio == MIPI_BKLT_EN_1 ? 0 : 1; intel_de_rmw(dev_priv, PP_CONTROL(index), EDP_BLC_ENABLE, value ? EDP_BLC_ENABLE : 0); -- 2.34.1