From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93F4FC6FD1C for ; Wed, 22 Mar 2023 12:36:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1345810E0F6; Wed, 22 Mar 2023 12:36:26 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8238E10E925 for ; Wed, 22 Mar 2023 12:36:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679488583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZEVZq83wbVrBX6YIpe57knDSAk+ax7b8c1a6ITeMnnE=; b=UawpxgmV2rbZhpnXEH+mMAM9lBdGX8bHhC/yUKgRwR/Q/D4CqpkjFD2HIXPlNRPAAwNgDR iW/NdZVumrBRDgjFGsuR6eXC5PiAjkQdwyfquu0o7nyHJpfVhApmrqwtQtJj0ZsIesMgqA KfdYicN6f7nfJ5VcRt0Q/HWjNG2846c= Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-mZs2awXFMgiVz6bvqt1r1A-1; Wed, 22 Mar 2023 08:36:22 -0400 X-MC-Unique: mZs2awXFMgiVz6bvqt1r1A-1 Received: by mail-io1-f72.google.com with SMTP id f15-20020a05660215cf00b00752dd002fd1so9512466iow.3 for ; Wed, 22 Mar 2023 05:36:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679488581; h=content-transfer-encoding:mime-version:organization:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ZEVZq83wbVrBX6YIpe57knDSAk+ax7b8c1a6ITeMnnE=; b=DJZAlq9+D+onYPuVuLCpsFVm9FtDtfJT++UTnVt7arK60Nhtj13iNUXP/JidVVN73t nR52MavU4Fa+yHEmEL98lxXET7QDSJTFBoVrb3YjJwJA3jN1QbKKKjHo6giKL2ViATYz JF6Y0G1vhHunn8h42y3uBQXU+fYyVd50ZxPR7RY7hiAs2YvSHkfZCxEY+Via9K7myv53 Jxek+Zdf4ii/SSfKe+m9dfjyHRcgnoMinyuIXuhqRC7cG9qtbQekrbB7YeVhPAAHPqdF E0Mza3iMAIVoGCUZq54O16qjPkK8eCqpBTf7napzz6eWN9DgpNtUSuOHsPc+cuM9oqWI GiAw== X-Gm-Message-State: AO0yUKU7cLnwPJdK3OP4CtiR4CNOZ417EZj4XonyGzZOY4h8tUmmQ5VW Wqz2ysJYtTtcCiyRarxFLXWrv5+tG8ViUErkYbGqQToHgMimuX5kWqeav+OTOSiMXMbPI083ueA l9ypNGwuhvBhOGNSEmrjCxkGHy2KS X-Received: by 2002:a6b:5b15:0:b0:73d:eb4b:345e with SMTP id v21-20020a6b5b15000000b0073deb4b345emr4250332ioh.6.1679488581506; Wed, 22 Mar 2023 05:36:21 -0700 (PDT) X-Google-Smtp-Source: AK7set+s1bVDw/httDHazd/bVKfPTyFl2eUE5yP3x7lZIEV1uxid79azuha2BxjfoT9XqWVJ/KVk0w== X-Received: by 2002:a6b:5b15:0:b0:73d:eb4b:345e with SMTP id v21-20020a6b5b15000000b0073deb4b345emr4250309ioh.6.1679488581235; Wed, 22 Mar 2023 05:36:21 -0700 (PDT) Received: from redhat.com ([38.15.36.239]) by smtp.gmail.com with ESMTPSA id f29-20020a02241d000000b003a69bd12c6dsm4820604jaa.58.2023.03.22.05.36.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Mar 2023 05:36:20 -0700 (PDT) Date: Wed, 22 Mar 2023 06:36:14 -0600 From: Alex Williamson To: Jason Gunthorpe Message-ID: <20230322063614.571699e4.alex.williamson@redhat.com> In-Reply-To: References: <20230317091557.196638a6.alex.williamson@redhat.com> <20230320165217.5b1019a4.alex.williamson@redhat.com> <20230321143122.632f7e63.alex.williamson@redhat.com> <20230321150112.1c482380.alex.williamson@redhat.com> <20230321164737.62b45132.alex.williamson@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "mjrosato@linux.ibm.com" , "jasowang@redhat.com" , "Hao, Xudong" , "peterx@redhat.com" , "Xu, Terrence" , "chao.p.peng@linux.intel.com" , "linux-s390@vger.kernel.org" , "Liu, Yi L" , "kvm@vger.kernel.org" , "lulu@redhat.com" , "joro@8bytes.org" , "nicolinc@nvidia.com" , "Zhao, Yan Y" , "intel-gfx@lists.freedesktop.org" , "eric.auger@redhat.com" , "intel-gvt-dev@lists.freedesktop.org" , "yi.y.sun@linux.intel.com" , "cohuck@redhat.com" , "shameerali.kolothum.thodi@huawei.com" , "suravee.suthikulpanit@amd.com" , "robin.murphy@arm.com" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 22 Mar 2023 09:27:16 -0300 Jason Gunthorpe wrote: > On Tue, Mar 21, 2023 at 04:47:37PM -0600, Alex Williamson wrote: > > On Tue, 21 Mar 2023 19:20:37 -0300 > > Jason Gunthorpe wrote: > > > > > On Tue, Mar 21, 2023 at 03:01:12PM -0600, Alex Williamson wrote: > > > > > > > > Though it would be nice if qemu didn't need two implementations so Yi > > > > > I'd rather see a new info in this series as well and qemu can just > > > > > consistently use dev_id and never bdf in iommufd mode. > > > > > > > > We also need to consider how libvirt determines if QEMU has the kernel > > > > support it needs to pass file descriptors. It'd be a lot cleaner if > > > > this aligned with the introduction of vfio cdevs. > > > > > > Yes, that would be much better if it was one package. > > > > > > But this is starting to grow and we have so many threads that need to > > > progress blocked on this cdev enablement :( > > > > > > Could we go forward with the cdev main patches and kconfig it to > > > experimental or something while the rest of the parts are completed > > > and tested through qemu? ie move the vfio-pci reset enablment to after > > > the cdev patches? > > > > We need to be able to guarantee that there cannot be any significant > > builds of the kernel with vfio cdev support if our intention is to stage > > it for libvirt. We don't have a global EXPERIMENTAL config option any > > more. Adding new code under BROKEN seems wrong. Fedora ships with > > STAGING enabled. A sternly worded Kconfig entry is toothless. What is > > the proposed mechanism to make this not look like a big uncompiled code > > dump? Thanks, > > I would suggest a sternly worded kconfig and STAGING. > > This isn't such a big issue, we are trying to say that a future > released qemu is not required to work on older kernels with a STAGING > kconfig mark. > > IOW we are saying that qemu release X.0 with production iommufd > requires kernel version > x.y and just lightly reflecting this into > the kconfig. > > qemu should simply not support iommufd if it finds itself on a old > kernel. Inferring features based on kernel versions doesn't work in a world where downstreams backport features to older kernels. Thanks, Alex