From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5409FC7EE25 for ; Thu, 8 Jun 2023 19:07:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C012710E60A; Thu, 8 Jun 2023 19:07:35 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6EBF110E60A; Thu, 8 Jun 2023 19:07:33 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C91FF6507B; Thu, 8 Jun 2023 19:07:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9AFDC433EF; Thu, 8 Jun 2023 19:07:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686251252; bh=GCMwx5k3Bt73ybwU+xYV6fYC/0AQ7aBIYHCUpkvNKfo=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=IMVbHFLxBjjj08+tTY4mqBYXPu+yPkr26OZEBnmqwftRD4Q1SIAVbxtVB+RaEhaTB 9YNpxhOb06DUNpsGWpqlO8z9M/UoGEk2AM7sufDW3RJNemcOsnAqYtglNCuAJpE+kf JUNbc9ZTxw7AcQ/hSPwWfQdyFV4yp8l+IAq+TPrnPI702kcblJyStDWHqfH3yQj13S t0Qutj14xL88vuhjZ7Z7pf9c2BxwZj+zB62b8uEzHzrF0cwWx7KsTwLNS7kF2x5DgT 9sI7zqmisychBq+ZtaxoiQBolhnEvyYOtA7a5hsVEwn9EOwYNv2+9Uz/yX7pGykML/ Wog9TxmEmNR5g== Date: Thu, 8 Jun 2023 14:07:30 -0500 From: Bjorn Helgaas To: Sui Jingfeng <15330273260@189.cn> Message-ID: <20230608190730.GA1209607@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230608114322.604887-2-15330273260@189.cn> Subject: Re: [Intel-gfx] [PATCH v3 1/4] PCI/VGA: tidy up the code and comment format X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Somalapuram Amaranath , Karol Herbst , nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, YiPeng Chai , Mario Limonciello , Sui Jingfeng , David Airlie , Yi Liu , kvm@vger.kernel.org, amd-gfx@lists.freedesktop.org, Jason Gunthorpe , Ben Skeggs , linux-pci@vger.kernel.org, Andrey Grodzovsky , Kevin Tian , Lijo Lazar , Daniel Vetter , Bokun Zhang , intel-gfx@lists.freedesktop.org, Maxime Ripard , loongson-kernel@lists.loongnix.cn, Abhishek Sahu , Rodrigo Vivi , Bjorn Helgaas , Yishai Hadas , Li Yi , Pan Xinhui , linux-kernel@vger.kernel.org, Thomas Zimmermann , Cornelia Huck , Alex Deucher , Christian Konig , Hawking Zhang Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Capitalize subject to match ("Tidy ...") On Thu, Jun 08, 2023 at 07:43:19PM +0800, Sui Jingfeng wrote: > From: Sui Jingfeng > > This patch replaces the leading space with a tab and removes the double > blank line, no functional change. Can you move this to the end of the series? The functional changes are more likely to be backported, and I think the backport may be a little easier without the cleanup in the middle. > /* we could in theory hand out locks on IO and mem > - * separately to userspace but it can cause deadlocks */ > + * separately to userspace but it can cause deadlocks > + */ Since you're touching this anyway, can you update it to the conventional multi-line comment style: /* * We could in theory ... */ And capitalize "We", add a period at end, and rewrap to fill 78 columns or so? Same for other comments below. > +++ b/include/linux/vgaarb.h > @@ -23,9 +23,7 @@ > * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER > * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING > * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER > - * DEALINGS > - * IN THE SOFTWARE. > - * > + * DEALINGS IN THE SOFTWARE. > */ Can you make a separate patch to replace this entire copyright notice with the appropriate SPDX-License-Identifier header? Documentation/process/license-rules.rst has details. Bjorn