From: Lucas De Marchi <lucas.demarchi@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [CI 22/22] drm/i915/lnl: Start using CDCLK through PLL
Date: Tue, 19 Sep 2023 12:21:28 -0700 [thread overview]
Message-ID: <20230919192128.2045154-22-lucas.demarchi@intel.com> (raw)
In-Reply-To: <20230919192128.2045154-1-lucas.demarchi@intel.com>
From: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Introduce correspondent definitions for choosing between CD2X CDCLK
and PLL CDCLK as a source. All the entries in cdclk table for xe2lpd are
defined with PLL CDCLK as source, so simply set it. Also
skl_cdclk_decimal() shouldn't be set in CDCLK_CTL anymore, so skip it
for display version 20 and above.
v2:
- Remove unneeded comment and use REG_BIT() (Matt Roper)
- Rename CDCLK_SOURCE_SEL_CDCLK_PLL() to MDCLK_SOURCE_SEL_CDCLK_PLL
to match spec (Lucas)
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/display/intel_cdclk.c | 9 +++++++--
drivers/gpu/drm/i915/i915_reg.h | 1 +
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_cdclk.c b/drivers/gpu/drm/i915/display/intel_cdclk.c
index 4cde78db83a1..b55a3f75f392 100644
--- a/drivers/gpu/drm/i915/display/intel_cdclk.c
+++ b/drivers/gpu/drm/i915/display/intel_cdclk.c
@@ -1906,8 +1906,7 @@ static void _bxt_set_cdclk(struct drm_i915_private *dev_priv,
dg2_cdclk_squash_program(dev_priv, waveform);
val = bxt_cdclk_cd2x_div_sel(dev_priv, clock, vco) |
- bxt_cdclk_cd2x_pipe(dev_priv, pipe) |
- skl_cdclk_decimal(cdclk);
+ bxt_cdclk_cd2x_pipe(dev_priv, pipe);
/*
* Disable SSA Precharge when CD clock frequency < 500 MHz,
@@ -1916,6 +1915,12 @@ static void _bxt_set_cdclk(struct drm_i915_private *dev_priv,
if ((IS_GEMINILAKE(dev_priv) || IS_BROXTON(dev_priv)) &&
cdclk >= 500000)
val |= BXT_CDCLK_SSA_PRECHARGE_ENABLE;
+
+ if (DISPLAY_VER(dev_priv) >= 20)
+ val |= MDCLK_SOURCE_SEL_CDCLK_PLL;
+ else
+ val |= skl_cdclk_decimal(cdclk);
+
intel_de_write(dev_priv, CDCLK_CTL, val);
if (pipe != INVALID_PIPE)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index d67f381050dc..e0ea2dc13556 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -5882,6 +5882,7 @@ enum skl_power_gate {
#define CDCLK_FREQ_540 REG_FIELD_PREP(CDCLK_FREQ_SEL_MASK, 1)
#define CDCLK_FREQ_337_308 REG_FIELD_PREP(CDCLK_FREQ_SEL_MASK, 2)
#define CDCLK_FREQ_675_617 REG_FIELD_PREP(CDCLK_FREQ_SEL_MASK, 3)
+#define MDCLK_SOURCE_SEL_CDCLK_PLL REG_BIT(25)
#define BXT_CDCLK_CD2X_DIV_SEL_MASK REG_GENMASK(23, 22)
#define BXT_CDCLK_CD2X_DIV_SEL_1 REG_FIELD_PREP(BXT_CDCLK_CD2X_DIV_SEL_MASK, 0)
#define BXT_CDCLK_CD2X_DIV_SEL_1_5 REG_FIELD_PREP(BXT_CDCLK_CD2X_DIV_SEL_MASK, 1)
--
2.40.1
next prev parent reply other threads:[~2023-09-19 19:21 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 19:21 [Intel-gfx] [CI 01/22] drm/i915/xelpdp: Add XE_LPDP_FEATURES Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 02/22] drm/i915/lnl: Add display definitions Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 03/22] drm/i915/xe2lpd: FBC is now supported on all pipes Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 04/22] drm/i915/display: Remove FBC capability from fused off pipes Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 05/22] drm/i915: Re-order if/else ladder in intel_detect_pch() Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 06/22] drm/i915/xe2lpd: Add fake PCH Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 07/22] drm/i915/xe2lpd: Treat cursor plane as regular plane for DDB allocation Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 08/22] drm/i915/xe2lpd: Don't try to program PLANE_AUX_DIST Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 09/22] drm/i915/xe2lpd: Register DE_RRMR has been removed Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 10/22] drm/i915/display: Fix style and conventions for DP AUX regs Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 11/22] drm/i915/display: Use _PICK_EVEN_2RANGES() in " Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 12/22] drm/i915/xe2lpd: Re-order " Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 13/22] drm/i915/xe2lpd: Handle port AUX interrupts Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 14/22] drm/i915/xe2lpd: Read pin assignment from IOM Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 15/22] drm/i915/xe2lpd: Enable odd size and panning for planar yuv Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 16/22] drm/i915/xe2lpd: Add support for HPD Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 17/22] drm/i915/xe2lpd: Extend Wa_15010685871 Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 18/22] drm/i915/lnl: Add gmbus/ddc support Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 19/22] drm/i915/lnl: Add CDCLK table Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 20/22] drm/i915/xe2lpd: Add display power well Lucas De Marchi
2023-09-19 19:21 ` [Intel-gfx] [CI 21/22] drm/i915/xe2lpd: Add DC state support Lucas De Marchi
2023-09-19 19:21 ` Lucas De Marchi [this message]
2023-09-19 22:37 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,01/22] drm/i915/xelpdp: Add XE_LPDP_FEATURES Patchwork
2023-09-19 22:37 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-19 22:55 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-09-20 10:11 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2023-09-21 15:24 ` Lucas De Marchi
2023-09-20 16:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,01/22] drm/i915/xelpdp: Add XE_LPDP_FEATURES (rev2) Patchwork
2023-09-20 16:03 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2023-09-20 16:19 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230919192128.2045154-22-lucas.demarchi@intel.com \
--to=lucas.demarchi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).