From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0E2ECD6107 for ; Mon, 9 Oct 2023 16:38:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6890710E131; Mon, 9 Oct 2023 16:38:41 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 588B810E131 for ; Mon, 9 Oct 2023 16:38:40 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 665A960304; Mon, 9 Oct 2023 16:38:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8EF2C433C7; Mon, 9 Oct 2023 16:38:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696869519; bh=MSbNJzxR5Uxb0K+7ztElxHBM3Hj8ixSJi5qLk0iBaMI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QGwJpxqDz0aWM/BosmKez3lWAzKO+tIizIY36faOYAH58uTLnp/LRvmv+60FlDGVe j+nJdg6GSQNkrt2VQyGWEgLwrD8L9SERIVo2+5HUKmwIUtodiwZ6jnCQsc8ShIslMn 6kkKaaC7DRHQ/B5LgLHxL/mCEleCGkegj26CeiHwZGAUXnmeUbYw4NvJ0Ps/jt5v8A uoDLD68YHxnJ/ztUMTWuuJVCLSR5Z4dy6qIYEi1mEWwH5PSODGxwFCcWfmj32QBYsl GmaRQP3mNh23EAW9bZCm31L9FDMjQet0Sx7tqfFJ89tjtX7gxxXAyWGgJICUSLOGZD cmCfoaJPEy/RA== Date: Mon, 9 Oct 2023 09:38:37 -0700 From: Nathan Chancellor To: Masahiro Yamada Message-ID: <20231009163837.GA1153868@dev-arch.thelio-3990X> References: <48f11648d7169687e7242e4c9b4694a0c03c4263.1696595500.git.jani.nikula@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915: drop -Wall and related disables from cflags as redundant X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula , intel-gfx@lists.freedesktop.org, Nick Desaulniers , Arnd Bergmann , linux-kbuild@vger.kernel.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sun, Oct 08, 2023 at 12:28:46AM +0900, Masahiro Yamada wrote: > On Fri, Oct 6, 2023 at 9:35 PM Jani Nikula wrote: > > > > The kernel top level Makefile, and recently scripts/Makefile.extrawarn, > > have included -Wall, and the disables -Wno-format-security and > > $(call cc-disable-warning,frame-address,) for a very long time. They're > > redundant in our local subdir-ccflags-y and can be dropped. > > > > Cc: Arnd Bergmann > > Cc: Nick Desaulniers > > Cc: Nathan Chancellor > > Cc: Masahiro Yamada > > Signed-off-by: Jani Nikula > > > I made a similar suggestion in the past > https://lore.kernel.org/dri-devel/20190515043753.9853-1-yamada.masahiro@socionext.com/ > > So, I am glad that Intel has decided to de-duplicate the flags. > > > > I think you can drop more flags. > > For example, > > subdir-ccflags-y += -Wno-sign-compare > > > It is set by scripts/Makefile.extrawarn > unless W=3 is passed. > > > If W=3 is set by a user, -Wsign-compare should be warned > as it is the user's request. > > > drivers/gpu/drm/i915/Makefile negates W=3. > There is no good reason to do so. > > > Same applied to > > > subdir-ccflags-y += -Wno-shift-negative-value As I point out in my review of the second patch [1], I am not sure these should be dropped because -Wextra turns these warnings back on, at least for clang according to this build report [2] and my own testing, so they need to be disabled again. [1]: https://lore.kernel.org/20231006174550.GC3359308@dev-arch.thelio-3990X/ [2]: https://lore.kernel.org/202310070011.Fji48IBk-lkp@intel.com/ Cheers, Nathan.