From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B5E8C4828F for ; Thu, 8 Feb 2024 16:03:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8FE0410E906; Thu, 8 Feb 2024 16:03:44 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="QXka1czU"; dkim-atps=neutral Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5ACC610E00F; Thu, 8 Feb 2024 16:03:42 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 539FFCE1D80; Thu, 8 Feb 2024 16:03:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82305C433C7; Thu, 8 Feb 2024 16:03:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707408216; bh=Igdsqh4bs6NiYnvDyhbANp18ct18WHK41QmYJ0p6Duk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QXka1czU0HxJAe9/Z7tqp2IwCy9Q7ND1ud7yKWgr0aPaEVbYVwqMOntZqEIM7tDup fyZ/7DXkg7PF38L7oykrP7viPizC7oA/enqhJFWWvgGBGU7osfq8yChKKHb+9vVdwO elNtxaGsUW1a9WOhIyyvO4IMI+3unJKVWXzamEiVLdFxl3TgXEkfdVfgEC6XFo2r7o /Q9X/yELfNXpTjnehQAQOAIH3aiUBAkAAavp404eHDHl5D5E47vxGbgAJYonZmal0W e9Dm1oRowc9Ml0tArZvIPSo8GFRBsC+d1PMwvQis4p2xEKNRIV9M7qI6OXS9on4RmR jdnJQ2p9qRXJA== Date: Thu, 8 Feb 2024 08:03:35 -0800 From: "Darrick J. Wong" To: Andrew Morton Cc: Matthew Wilcox , Christoph Hellwig , Hugh Dickins , Chandan Babu R , David Howells , Jarkko Sakkinen , Dave Hansen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Christian Koenig , Huang Rui , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, x86@kernel.org, linux-sgx@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, keyrings@vger.kernel.org Subject: Re: [PATCH 2/2] xfs: disable large folio support in xfile_create Message-ID: <20240208160335.GN6184@frogsfrogsfrogs> References: <20240110092109.1950011-1-hch@lst.de> <20240110092109.1950011-3-hch@lst.de> <20240110175515.GA722950@frogsfrogsfrogs> <20240110200451.GB722950@frogsfrogsfrogs> <20240111140053.51948fb3ed10e06d8e389d2e@linux-foundation.org> <20240112022250.GU723010@frogsfrogsfrogs> <20240207175621.dd773204e7928dbeee7a92bf@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240207175621.dd773204e7928dbeee7a92bf@linux-foundation.org> X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Feb 07, 2024 at 05:56:21PM -0800, Andrew Morton wrote: > On Thu, 11 Jan 2024 18:22:50 -0800 "Darrick J. Wong" wrote: > > > On Thu, Jan 11, 2024 at 10:45:53PM +0000, Matthew Wilcox wrote: > > > On Thu, Jan 11, 2024 at 02:00:53PM -0800, Andrew Morton wrote: > > > > On Wed, 10 Jan 2024 12:04:51 -0800 "Darrick J. Wong" wrote: > > > > > > > > > > > Fixing this will require a bit of an API change, and prefeably sorting out > > > > > > > the hwpoison story for pages vs folio and where it is placed in the shmem > > > > > > > API. For now use this one liner to disable large folios. > > > > > > > > > > > > > > Reported-by: Darrick J. Wong > > > > > > > Signed-off-by: Christoph Hellwig > > > > > > > > > > > > Can someone who knows more about shmem.c than I do please review > > > > > > https://lore.kernel.org/linux-xfs/20240103084126.513354-4-hch@lst.de/ > > > > > > so that I can feel slightly more confident as hch and I sort through the > > > > > > xfile.c issues? > > > > > > > > > > > > For this patch, > > > > > > Reviewed-by: Darrick J. Wong > > > > > > > > > > ...except that I'm still getting 2M THPs even with this enabled, so I > > > > > guess either we get to fix it now, or create our own private tmpfs mount > > > > > so that we can pass in huge=never, similar to what i915 does. :( > > > > > > > > What is "this"? Are you saying that $Subject doesn't work, or that the > > > > above-linked please-review patch doesn't work? > > > > > > shmem pays no attention to the mapping_large_folio_support() flag, > > > so the proposed fix doesn't work. It ought to, but it has its own way > > > of doing it that predates mapping_large_folio_support existing. > > > > Yep. It turned out to be easier to fix xfile.c to deal with large > > folios than I thought it would be. Or so I think. We'll see what > > happens on fstestscloud overnight. > > Where do we stand with this? Should I merge these two patches into > 6.8-rcX, cc:stable? This patchset doesn't actually fix the problem, so no, let's not merge it. For 6.9 we'll make xfile.c clean w.r.t. large folios: https://lore.kernel.org/linux-xfs/20240129143502.189370-1-hch@lst.de/ I don't think we need a 6.8 backport since xfile.c is only used by an experimental feature that is default n in kconfig. --D