From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21B96C3ABA2 for ; Mon, 16 Sep 2024 11:00:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BF3B110E0A6; Mon, 16 Sep 2024 11:00:58 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="NA9c8Nyz"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id D5F1510E0A6 for ; Mon, 16 Sep 2024 11:00:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726484456; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6WU8wjEM5waBEtcNYw4l2YQcbb7TE6+vCphAyrZI7KM=; b=NA9c8NyzgZ29VrCooOFlbgfpwj75okR2bpowrxuLbrHmHIov/FuBr9+TR2aviz/+wX6e48 IAag+zSrVk9NeMFEWNXVeCvAcnI/0IVvRVKw9VR0u/YL2a4MuzyF4ItOSn+6j3w3WslmR1 ZE2yKSEErJGC5CpqPA2Kh6tLVzRT/NM= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-47-b7S5_H2HO0iLqyF7u3mM6g-1; Mon, 16 Sep 2024 07:00:55 -0400 X-MC-Unique: b7S5_H2HO0iLqyF7u3mM6g-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3787ea79dceso1089178f8f.2 for ; Mon, 16 Sep 2024 04:00:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726484454; x=1727089254; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6WU8wjEM5waBEtcNYw4l2YQcbb7TE6+vCphAyrZI7KM=; b=rEYtaHCEu79ErpYA10l1oWbreSNwyR6RwcREyEijs9KcIk5WV0IX2MVf53CWQMDn8m 3FdGu1FIxGS3H+0hIM1R6Wqw+UyXNWjoJacOwZgIbrsDs6t0SWE3qD/TAW6wFAqF0U9D Cj9c/olegaR9z8lIKQ+UO9GGfkBudNALGmsB+AYj3WM1BTiazo3hoOo0N+WUgsSRyo5D tGX8NSwaXhVsOexlEBqIWSoNaWulNtaDi70al3JTaqmd0Qc4YDqPpVl98sOf47pYaxgG +cGKu3Td8KsoOLb/45UbtNJ5TNqwrc300xsDEVEiQtpbx1I89j7eOFjnIvLJFFoheeeM WLAQ== X-Forwarded-Encrypted: i=1; AJvYcCUkFMVRASpf//qcM+nTOvwoNrrB5hdvjjl6/Vw7h2tHlKsZRDcN5HPtzC+Yygw0UbYXhySV7Pf+Jmc=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwKEC7Xg1b0i0BXLvL6tAJ1TQ6n5lD9Fa/u6mubPDzayfsCspXF v9XYLbX4x/ji86koi4UL0W1+RPqaCj9wZsRbJ11b6sl8/dWTUT6WZUYUjMe58u8sjpnuWtmhUAe wO8SDWk6KRzjaF9voVfLmbamyf+kuc4pX6ok8q7JVNyP+YzJXDW0SX0UZbXUJUFeZXw== X-Received: by 2002:a5d:5f56:0:b0:374:ca16:e09b with SMTP id ffacd0b85a97d-378d61d5073mr7098344f8f.9.1726484454306; Mon, 16 Sep 2024 04:00:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHL0bDYkRLWR54cWHoQ6srXlo7gK64jJb064BDuwwm746fvy1r250h1Ko4v03+pz4HMLbwFTg== X-Received: by 2002:a5d:5f56:0:b0:374:ca16:e09b with SMTP id ffacd0b85a97d-378d61d5073mr7098298f8f.9.1726484453789; Mon, 16 Sep 2024 04:00:53 -0700 (PDT) Received: from localhost ([195.166.127.210]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42da24274dfsm74035955e9.45.2024.09.16.04.00.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Sep 2024 04:00:53 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Brian Norris , dri-devel@lists.freedesktop.org, Borislav Petkov , Julius Werner , Thomas Zimmermann , chrome-platform@lists.linux.dev, intel-gfx@lists.freedesktop.org, Hugues Bruant , Javier Martinez Canillas , Alex Deucher , Dan Carpenter , Helge Deller , Jani Nikula , Tzung-Bi Shih Subject: [PATCH v4 0/2] firmware: Avoid coreboot and sysfb to register a pdev for same framebuffer Date: Mon, 16 Sep 2024 13:00:24 +0200 Message-ID: <20240916110040.1688511-1-javierm@redhat.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hello, This is v4 of a fix to prevent both coreboot and sysfb drivers to register a platform device to setup a system framebuffer. It has been converted to a series since contains changes for both drivers, to prevent build issues on architectures that don't define a global struct screen_info. Patch #1 adds a sysfb_handles_screen_info() helper that can be used by drivers to check whether sysfb can use the data set in screen_info or not. Patch #2 makes the framebuffer_coreboot driver to use that helper to know if has to setup the system framebuffer or delegate that action to sysfb. I haven't dropped the collected tags from patch #2 due the logic being basically the same than in v3. The patches have only been compiled tested because I don't have access to a coreboot machine. Please let me know if you plan to merge both patches through the chrome-platforms tree or if you prefer to get merged through the drm-misc tree. Best regards, Javier Changes in v4: - New patch to add sysfb_handles_screen_info() helper (Thomas Zimmermann). - Use a sysfb_handles_screen_info() helper instead of screen_info_video_type() to fix build errors on platforms that don't define a struct screen_info (Thomas Zimmermann). Changes in v3: - Fix coreboot spelling to be all in lowercase (Julius Werner). Changes in v2: - Declare the struct screen_info as constant variable (Thomas Zimmermann). - Use screen_info_video_type() instead of checking the screen_info video types directly (Thomas Zimmermann). - Fix missing "device" word in a comment (Brian Norris). - Fix some mispellings in a comment (Brian Norris). - Change error code returned from -EINVAL to -ENODEV (Brian Norris). Javier Martinez Canillas (2): firmware: sysfb: Add a sysfb_handles_screen_info() helper function firmware: coreboot: Don't register a pdev if screen_info data is present .../firmware/google/framebuffer-coreboot.c | 14 ++++++++++++++ drivers/firmware/sysfb.c | 19 +++++++++++++++++++ include/linux/sysfb.h | 7 +++++++ 3 files changed, 40 insertions(+) -- 2.46.0