Re: [PATCH v3 4/4] drm/i915/dg2: Implement Wa_14022698537

Jani Nikula
2024-10-31T09:27:15Z

On Thu, 31 Oct 2024, Raag Jadav <raag.jadav@intel.com> wrote:
> On Wed, Oct 30, 2024 at 08:39:31PM +0200, Jani Nikula wrote:
>> On Wed, 30 Oct 2024, Raag Jadav <raag.jadav@intel.com> wrote:
>> > G8 power state entry is disabled due to a limitation on DG2, so we
>> > enable it from driver with Wa_14022698537. For now we enable it for
>> > all DG2 devices with the exception of a few, for which, we enable
>> > only when paired with whitelisted CPU models. This works with Native
>> > ASMP and reduces idle power consumption.
>
> ...
>
>> > +/* Wa_14022698537:dg2 */
>> > +static void i915_enable_g8(struct drm_i915_private *i915)
>> > +{
>> > + if (IS_DG2(i915)) {
>> > + if (IS_DG2_D(i915) && !intel_match_g8_cpu())
>> > + return;
>>
>> You don't need to check for DG2 twice.
>
> My understanding is that DG2_D is a subset of DG2.

Sorry, I misread the code. *facepalm*.

BR,
Jani.

>
>> > + snb_pcode_write_p(&i915->uncore, PCODE_POWER_SETUP,
>> > + POWER_SETUP_SUBCOMMAND_G8_ENABLE, 0, 0);
>> > + }
>> > +}
>
> Raag

--
Jani Nikula, Intel